From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Bruce Momjian <bruce@momjian.us>,
        Nathan Bossart <nathandbossart@gmail.com>,
        Magnus Hagander <magnus@hagander.net>,
        Corey Huinker <corey.huinker@gmail.com>,
        Jeff Davis <pgsql@j-davis.com>, jian he <jian.universality@gmail.com>,
        Matthias van de Meent <boekewurm+postgres@gmail.com>,
        Stephen Frost <sfrost@snowman.net>,
        Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
        Peter Smith <smithpb2250@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Statistics Import and Export
In-reply-to: <202411271557.gaewckwu64dm@alvherre.pgsql>
References: <202411271557.gaewckwu64dm@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Wed, 27 Nov 2024 16:57:35 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1869336.1732725865.1@sss.pgh.pa.us>
Date: Wed, 27 Nov 2024 11:44:25 -0500
Message-ID: <1869337.1732725865@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1869337.1732725865%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2024-Nov-27, Bruce Momjian wrote:
>> Would there be a default?

> There would be no default.  Running with no option given would raise an
> error.  The point is: you want to break scripts currently running
> --analyze-in-stages so that they can make a choice of which of these two
> modes to run.  Your proposal (as I understand it) is to remove the
> --analyze-in-stages option and add two other options.  My proposal is to
> keep --analyze-in-stages, but require it to have a specifier of which
> mode to run.  Both achieve what you want, but I think mine achieves it
> in a cleaner way.

I do not like the idea of breaking existing upgrade scripts,
especially not by requiring them to use a parameter that older
vacuumdb versions will reject.  That makes it impossible to have a
script that is version independent.  I really doubt that there is any
usability improvement to be had here that's worth that.

How about causing "--analyze-in-stages" (as currently spelled) to
be a no-op?  We could keep the behavior available under some other
name.

			regards, tom lane