From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
        Andres Freund <andres@anarazel.de>,
 Xuneng Zhou <xunengzhou@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: per backend WAL statistics
In-reply-to: <Z89-gxOVxtEP_w9d@paquier.xyz>
References: <Z8hLi1dGfPFc8AYy@ip-10-97-1-34.eu-west-3.compute.internal>
 <clef2a7wqnopfjw3jl7pbn25gko6m3fk2zctmtqjgyx6a7xw5j@sujsipmj4zif>
 <Z8iJUHn13NsSCYhj@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z8l6EMM4ImVoWRkg@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z8qHNelALLU6LiSy@paquier.xyz>
 <Z8qvQFG/70pt33E0@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z8ukEg7Z3KsNfEoo@paquier.xyz>
 <Z8v3YIvhNTrhzhZb@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z86Y7cDkebuIhsDj@paquier.xyz>
 <Z87SetO+E/QOayNP@ip-10-97-1-34.eu-west-3.compute.internal>
 <Z89-gxOVxtEP_w9d@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 11 Mar 2025 09:06:27 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1870852.1741749264.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 11 Mar 2025 23:14:24 -0400
Message-ID: <1870853.1741749264@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1870853.1741749264%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> And I guess that we're OK here, so applied.  That should be the last
> one.

Quite a few buildfarm members are not happy about the initialization
that 9a8dd2c5a added to PendingBackendStats.  For instance [1]:

gcc -std=3Dgnu99 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-=
after-statement -Werror=3Dvla -Wendif-labels -Wmissing-format-attribute -W=
format-security -fno-strict-aliasing -fwrapv -fexcess-precision=3Dstandard=
 -g -O2 -I. -I. -I../../../../src/include  -D_GNU_SOURCE -I/usr/include/li=
bxml2   -c -o pgstat_backend.o pgstat_backend.c
pgstat_backend.c:39:1: warning: missing braces around initializer [-Wmissi=
ng-braces]
 static PgStat_BackendPending PendingBackendStats =3D {0};
 ^
pgstat_backend.c:39:1: warning: (near initialization for \342\200\230Pendi=
ngBackendStats.pending_io\342\200\231) [-Wmissing-braces]

I guess that more than one level of braces is needed for this to
be fully correct?  Similar from ayu, batfish, boa, buri, demoiselle,
dhole, rhinoceros, shelduck, siskin.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Darowan=
a&dt=3D2025-03-11%2004%3A59%3A16&stg=3Dbuild