Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1uKd8w-00846k-ME
	for pgsql-hackers@arkaria.postgresql.org; Thu, 29 May 2025 13:17:58 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1uKd8v-008wK3-ER
	for pgsql-hackers@arkaria.postgresql.org; Thu, 29 May 2025 13:17:57 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1uKd8v-008wJv-4p
	for pgsql-hackers@lists.postgresql.org; Thu, 29 May 2025 13:17:57 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1uKd8s-000imh-0g
	for pgsql-hackers@lists.postgresql.org;
	Thu, 29 May 2025 13:17:56 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 54TDHqBA1876118;
	Thu, 29 May 2025 09:17:52 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Matheus Alcantara <matheusssilv97@gmail.com>
cc: Etsuro Fujita <etsuro.fujita@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Fixing memory leaks in postgres_fdw
In-reply-to: 
 <CAFY6G8fY=e8n1K=sHuXovgxEgRqN1Df5db230uF1KtffvWUT-Q@mail.gmail.com>
References: <2976982.1748049023@sss.pgh.pa.us>
 <CAPmGK17iOh6W25UswGcn5k75jEukSgLMpiaJEATcAZQTec7xxg@mail.gmail.com>
 <216286.1748202797@sss.pgh.pa.us> <519144.1748217540@sss.pgh.pa.us>
 <918254.1748288174@sss.pgh.pa.us>
 <CAFY6G8fEa9sZ1V9cJpMOZAp6Wfa35U_rE0Y=eoQLS2G3OAqiAw@mail.gmail.com>
 <1346940.1748381911@sss.pgh.pa.us> <1696019.1748465792@sss.pgh.pa.us>
 <CAFY6G8fY=e8n1K=sHuXovgxEgRqN1Df5db230uF1KtffvWUT-Q@mail.gmail.com>
Comments: In-reply-to Matheus Alcantara <matheusssilv97@gmail.com>
	message dated "Thu, 29 May 2025 10:07:31 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1876116.1748524672.1@sss.pgh.pa.us>
Date: Thu, 29 May 2025 09:17:52 -0400
Message-ID: <1876117.1748524672@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1876117.1748524672%40sss.pgh.pa.us>
Precedence: bulk

Matheus Alcantara <matheusssilv97@gmail.com> writes:
> The only point is that I've just tried to apply the v5-0001 on top of
> the previous v4-000X patches and is raising an error:
>   git am v5-0001-Avoid-resource-leaks-when-a-dblink-connection-fai.patch
> Applying: Avoid resource leaks when a dblink connection fails.
> error: patch failed: contrib/dblink/dblink.c:105
> error: contrib/dblink/dblink.c: patch does not apply
> Patch failed at 0001 Avoid resource leaks when a dblink connection fails.

Yeah, it's not intended to be done in that order: the v5-0001 patch is
an independent thing.  I anticipate I'll have to rebase the other
patches after I push v5-0001.

Thanks for looking at it!

			regards, tom lane