From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgindent vs dtrace on macos
In-reply-to: <2876D3E9-AD31-4841-869B-CADDBF2EBC66@yesql.se>
References: <79ed5348-be7a-b647-dd40-742207186a22@2ndquadrant.com>
 <21042.1589983015@sss.pgh.pa.us>
 <fcbe3e68-19f8-ae3b-cf5a-3e420123826b@2ndquadrant.com>
 <FDCD46CA-C092-4B1D-B19E-314569AA3D88@yesql.se>
 <43461.1600300517@sss.pgh.pa.us>
 <2876D3E9-AD31-4841-869B-CADDBF2EBC66@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Thu, 17 Sep 2020 10:15:30 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <187726.1600357196.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 17 Sep 2020 11:39:56 -0400
Message-ID: <187727.1600357196@sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
>>> On that note, I
>>> wonder if we should add the plperl .xs generated files as exclusions t=
oo since
>>> we don't control that generator?

>> Not an issue I don't think; pgindent won't touch extensions other than
>> .c and .h.

> Sorry for being unclear, I meant the generated .c counterpart of the .xs=
 file.

Oh, I see.  Not sure.  For myself, I only care about files that survive
"make distclean" and get into a tarball, which those don't.  On the
other hand, if we fixed perlchunks.h and plperl_opmask.h then it's hard
to argue with worrying about SPI.c and Util.c, as those all have the
same lifespan.

I tried redoing the experiment of pgindenting all the tarball member
files, and found that we still have diffs in these generated files:

src/backend/utils/sort/qsort_tuple.c
src/common/kwlist_d.h =

src/interfaces/ecpg/preproc/c_kwlist_d.h =

src/interfaces/ecpg/preproc/ecpg_kwlist_d.h
src/pl/plpgsql/src/pl_reserved_kwlist_d.h =

src/pl/plpgsql/src/pl_unreserved_kwlist_d.h
src/pl/plpgsql/src/plerrcodes.h
src/pl/plpython/spiexceptions.h
src/pl/tcl/pltclerrcodes.h

To my eyes, what pgindent does to the *kwlist_d.h files is rather ugly,
so I'm inclined to make them exclusions rather than adjust the generator
script.  The others seem like we could tweak the relevant generators
fairly easily.

			regards, tom lane