Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhY3p-0002AY-6X for pgsql-hackers@arkaria.postgresql.org; Fri, 14 May 2021 13:41:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lhY3o-0000TL-3u for pgsql-hackers@arkaria.postgresql.org; Fri, 14 May 2021 13:41:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhY3n-0000TD-Sn for pgsql-hackers@lists.postgresql.org; Fri, 14 May 2021 13:40:59 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhY3l-0003eG-Op for pgsql-hackers@lists.postgresql.org; Fri, 14 May 2021 13:40:58 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 14EDerMV1880877; Fri, 14 May 2021 09:40:53 -0400 From: Tom Lane To: Pavel Borisov cc: Dilip Kumar , Alvaro Herrera , PostgreSQL Hackers Subject: Re: OOM in spgist insert In-reply-to: References: <20210513224933.GA20201@alvherre.pgsql> <1785221.1620954078@sss.pgh.pa.us> Comments: In-reply-to Pavel Borisov message dated "Fri, 14 May 2021 12:21:28 +0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1880875.1620999653.1@sss.pgh.pa.us> Date: Fri, 14 May 2021 09:40:53 -0400 Message-ID: <1880876.1620999653@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Pavel Borisov writes: > Now when checking for shortening of leaf tuple is added LongValuesOK > become slightly redundant. I'd propose to replace it with more legible name > as LongValuesOK doesn't mean they are warranted to be ok just that we can > try to shorten them? What about tryShortening, trySuffixing or > can(Try)ShortenTuple? That field name is part of the opclass API. I fear it's several years too late to rename it for no compelling reason. regards, tom lane