From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Peter Eisentraut <peter@eisentraut.org>,
        Tristan Partin <tristan@partin.io>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add malloc attribute to memory allocation functions
In-reply-to: <ak2EhhPxWaxPigsc@paquier.xyz>
References: <DJNFBUWD276K.2OPIYJQS75W84@partin.io>
 <924283.1783312014@sss.pgh.pa.us> <DJRMU1Z9461P.184EDJQZ9DH8D@partin.io>
 <2248c1c4-68f7-46dc-9e58-9ba9057da74e@eisentraut.org>
 <1847455.1783439616@sss.pgh.pa.us> <ak2EhhPxWaxPigsc@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 08 Jul 2026 07:58:14 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1885661.1783468446.1@sss.pgh.pa.us>
Date: Tue, 07 Jul 2026 19:54:06 -0400
Message-ID: <1885662.1783468446@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1885662.1783468446%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Additional question.  Does this help with requirements like the one
> listed in fe-exec.c for PQfreemem() under WIN32?

Yeah, I was wondering about that point too.  It would be really nice
to have automated checks for that.  Maybe the right thing to do here
(to start anyway) is to put in targeted annotations that address
specific pain points like that one.

One issue that'd have to be dealt with is that that would involve
putting annotations into the public header file libpq-fe.h.  We'd need
to be sure we do not break things for applications using compilers
other than what we built libpq with.  That seems reasonably easy to do
with some macro trickery, but it's a point to keep in mind.

			regards, tom lane