Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmMSE-0002c3-La for pgsql-hackers@arkaria.postgresql.org; Thu, 27 May 2021 20:18:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lmMSD-0006vv-IA for pgsql-hackers@arkaria.postgresql.org; Thu, 27 May 2021 20:18:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmMSD-0006sH-A0 for pgsql-hackers@lists.postgresql.org; Thu, 27 May 2021 20:18:05 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmMSB-0007R8-CC for pgsql-hackers@postgresql.org; Thu, 27 May 2021 20:18:04 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 14RKHwmx1885751; Thu, 27 May 2021 16:17:58 -0400 From: Tom Lane To: Alvaro Herrera cc: Robert Haas , Dilip Kumar , Michael Paquier , Andres Freund , pgsql-hackers Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size? In-reply-to: <202105271934.mneyybkyeo66@alvherre.pgsql> References: <202105271934.mneyybkyeo66@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Thu, 27 May 2021 15:34:21 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1885749.1622146678.1@sss.pgh.pa.us> Date: Thu, 27 May 2021 16:17:58 -0400 Message-ID: <1885750.1622146678@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera writes: > Now about the former. If we do think that recompressing causes an > unacceptable 10% slowdown for every single VACUUM FULLs, then yeah we > should discuss changing that behavior -- maybe remove promises of > recompression and wait for pg15 to add "VACUUM (RECOMPRESS)" or > similar. > If it's a 10% slowdown of the only best times (variability unspecified) > and only in corner cases (unlogged tables with no indexes that fit in > shared buffers), then I don't think we should bother. BTW, perhaps I should clarify my goal here: it's to cut off expending further effort on this feature during v14. If we can decide that the existing performance situation is acceptable, I'm content with that decision. But if we're to start designing new user-visible behavior to satisfy performance objections, then I'd prefer to remove this VACUUM behavior altogether for now. regards, tom lane