Feedback-ID: i131946ab:Fastmail
Message-ID: <18865902-c612-9fdf-8222-6ce09d5a7b72@enterprisedb.com>
Date: Thu, 2 Feb 2023 23:39:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: Underscores in numeric literals
Content-Language: en-US
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <84aae844-dc55-a4be-86d9-4f0fa405cc97@enterprisedb.com>
 <4015800.1672152932@sss.pgh.pa.us>
 <dd65d444-4aad-6c49-6df7-91200097a6c7@dunslane.net>
 <CAEZATCUJPJHMokBEm4cYmq0t8T5hXMiKz6Rkqj5+EWOWF-==3A@mail.gmail.com>
 <CAEZATCVw8pqVn48S5ek6ZtAqWzjrJ+2q0-w3J=pOBKULwSPb-g@mail.gmail.com>
 <de21d0dc-cc09-430d-f74e-1121028632cf@enterprisedb.com>
 <CAEZATCVedWe+u8_1iBzmJ5DBLxkEmS3RyJo6XGbaR62yvhrbZA@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAEZATCVedWe+u8_1iBzmJ5DBLxkEmS3RyJo6XGbaR62yvhrbZA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/18865902-c612-9fdf-8222-6ce09d5a7b72%40enterprisedb.com>
Precedence: bulk

On 31.01.23 17:09, Dean Rasheed wrote:
> On Tue, 31 Jan 2023 at 15:28, Peter Eisentraut
> <peter.eisentraut@enterprisedb.com> wrote:
>>
>> Did you have any thoughts about what to do with the float types?  I
>> guess we could handle those in a separate patch?
>>
> 
> I was assuming that we'd do nothing for float types, because anything
> we did would necessarily impact their performance.

Yeah, as long as we are using strtof() and strtod() we should just leave 
it alone.  If we have break that open and hand-code something, we can 
reconsider it.

So I think you could go ahead with committing your patch and we can 
consider this topic done for now.