Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1egJnR-000257-LX
	for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Jan 2018 00:29:09 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1egJnP-0005Yu-OG
	for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Jan 2018 00:29:07 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1egJnP-0005Yk-HT
	for pgsql-hackers@lists.postgresql.org; Tue, 30 Jan 2018 00:29:07 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1egJnL-0000ys-4Y
	for pgsql-hackers@postgresql.org; Tue, 30 Jan 2018 00:29:07 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w0U0SxHY018876;
	Mon, 29 Jan 2018 19:28:59 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Oliver Ford <ojford@gmail.com>
cc: Erik Rijkers <er@xs4all.nl>, Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add RANGE with values and exclusions clauses to the Window
 Functions
In-reply-to: 
 <CAGMVOdtkUxmN8iLF5cQSF7+8kZA_fDYuBBcN0BvjDKbOjCvUdw@mail.gmail.com>
References: 
 <CAGMVOdu9sivPAxbNN0X+q19Sfv9edEPv=HibOJhB14TJv_RCQg@mail.gmail.com>
 <b2374b9461c349b17b50c77f3a70e1a1@xs4all.nl>
 <CAGMVOdsopg5ZAuJh9+ceq-s0pU2qqZsZn-jbL4A1c=h1iWaZVA@mail.gmail.com>
 <CAGMVOdvrZCwJg0BngM9GMO+LK=j20vhSfdk1gTTBNNH311Vgsw@mail.gmail.com>
 <bc8a1d397fa81d6ae33c297d0224184b@xs4all.nl>
 <2c084c1c2bf599ceb2afa87874de8bc1@xs4all.nl>
 <CAGMVOdvETRCKpeT06Uoq5RsNUOdH7d1iYy7C1Pze=L5=gBzs-Q@mail.gmail.com>
 <cdbe62a6eaddae00fa770c09ed346fc0@xs4all.nl>
 <CAGMVOdttRSUU3=tjgdhr902HmUVL1GLQWG0ZTVXi7OY59Xo0Xw@mail.gmail.com>
 <13279.1515535159@sss.pgh.pa.us>
 <CAGMVOdtYSNJusckQ_9vBkMsZBQzan=Uw-Z-uYG2fD9rZ2TP7pA@mail.gmail.com>
 <4139.1515567978@sss.pgh.pa.us>
 <CAGMVOdvJMfOzm0v4psCoAaVGfCbdFwNKzaSEhfTj8rE9UCz-eQ@mail.gmail.com>
 <c30e6457a6de09d26425af997f71996e@xs4all.nl>
 <CAGMVOdtGe=30u6D2WqwvWchE+-yNb9jKnEeG8BHyw7jHiGPR7w@mail.gmail.com>
 <27788.1517069693@sss.pgh.pa.us>
 <CAGMVOduaHeA8q+kvCqX-UfuV_=jHvb-XK+1KJEiNy80Drk=y_A@mail.gmail.com>
 <10568.1517261334@sss.pgh.pa.us> !
 <CAGMVOdtJZCXQRO1HQvGWTfzxrP0cTtxWXfXJ58EC2f2GgSQ+9w@mail.gmail.com>
 <14068.1517266223@sss.pgh.pa.us>
 <CAGMVOdtkUxmN8iLF5cQSF7+8kZA_fDYuBBcN0BvjDKbOjCvUdw@mail.gmail.com>
Comments: In-reply-to Oliver Ford <ojford@gmail.com>
	message dated "Mon, 29 Jan 2018 23:05:39 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18874.1517272139.1@sss.pgh.pa.us>
Date: Mon, 29 Jan 2018 19:28:59 -0500
Message-ID: <18875.1517272139@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Another thing I'm a little confused by is the precise API for the in_range
support functions (the lack of any documentation for it doesn't help).
I wonder why you chose to provide two support functions per datatype
combination rather than one with an additional boolean argument.
In fact, it almost seems like the "end" flag could already do the
job, though I may be missing something.  As-is, it seems like this
setup involves a lot of duplicate code and catalog entries ... what
are we gaining from that?

			regards, tom lane