From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <pchampion@vmware.com>
cc: "sfrost@snowman.net" <sfrost@snowman.net>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Fixing cache pollution in the Kerberos test suite
In-reply-to: <0c0cbc9b9a7a1bcd6e78e5eddf706ddeba0293da.camel@vmware.com>
References: <1fcb175bafef6560f47a8c31229fa7c938486b8d.camel@vmware.com>
 <20210125183645.GF27507@tamriel.snowman.net>
 <1894698.1611600541@sss.pgh.pa.us>
 <0c0cbc9b9a7a1bcd6e78e5eddf706ddeba0293da.camel@vmware.com>
Comments: In-reply-to Jacob Champion <pchampion@vmware.com>
	message dated "Mon, 25 Jan 2021 19:00:41 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1895342.1611601474.1@sss.pgh.pa.us>
Date: Mon, 25 Jan 2021 14:04:34 -0500
Message-ID: <1895343.1611601474@sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <pchampion@vmware.com> writes:
> On Mon, 2021-01-25 at 13:49 -0500, Tom Lane wrote:
>> Yeah, changing global state is just awful.  However, I don't
>> actually see any change here (RHEL8):

> Interesting. I'm running Ubuntu 20.04:

Hmm.  I'll poke harder.

>> Also, why are you only setting the ENV variable within narrow parts
>> of the test script?  I'd be inclined to enforce it throughout.

> I considered it and decided I didn't want to pollute the server's
> environment with it, since the server shouldn't need the client cache.

True, but if it did try to access the cache, accessing the user's
normal cache would be strictly worse than accessing the test cache.

			regards, tom lane