From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org,
        Thomas Munro <thomas.munro@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>,
        Melanie Plageman <melanieplageman@gmail.com>
Subject: Re: Adding CI to our tree
In-reply-to: <20211213224720.w24etz46zu6mn3er@alap3.anarazel.de>
References: <20211001222752.wrz7erzh4cajvgp6@alap3.anarazel.de>
 <20211213211223.vkgg3wwiss2tragj@alap3.anarazel.de>
 <20211213220250.GH17618@telsasoft.com>
 <20211213224720.w24etz46zu6mn3er@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 13 Dec 2021 14:47:20 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <189633.1639437292.1@sss.pgh.pa.us>
Date: Mon, 13 Dec 2021 18:14:52 -0500
Message-ID: <189634.1639437292@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/189634.1639437292%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2021-12-13 16:02:50 -0600, Justin Pryzby wrote:
>> sudo is used exactly twice; maybe it's not needed at all ?

> The macos one is needed, but the freebsd one indeed isn't.

I'm with Justin on this one.  I would view a script trying to
mess with /cores as a hostile act.  PG cores on macOS tend to
be extremely large and can fill up your disk fairly quickly
if you don't know they're being accumulated.  I think it's okay
to suggest in the documentation that people might want to allow
cores to be dropped, but the script has NO business trying to
force that.

			regards, tom lane