From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Coleman <jtc331@gmail.com>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Michael Paquier <michael@paquier.xyz>,
        Rafia Sabih <rafia.pghackers@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
        Simon Riggs <simon@2ndquadrant.com>,
        Shaun Thomas <shaun.thomas@2ndquadrant.com>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Alexander Korotkov <a.korotkov@postgrespro.ru>,
        PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
        Andreas Karlsson <andreas@proxel.se>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
In-reply-to: 
 <CAAaqYe_PZ7oX8-D9+YU2qAomc3=VxF3yTB3Xdf94FLgcoyadeA@mail.gmail.com>
References: 
 <CAAaqYe8hK3FpBRkAtTn1L_sETMUivoR=knoLf5by6Q7yLZnzTg@mail.gmail.com>
 <20200331163126.GA6532@alvherre.pgsql>
 <CAAaqYe_=y8biPXLdXENfVUTn-c8nXOu_NRL2Bwb5gLc+AZ5aHA@mail.gmail.com>
 <346.1585674268@sss.pgh.pa.us>
 <CAAaqYe_PZ7oX8-D9+YU2qAomc3=VxF3yTB3Xdf94FLgcoyadeA@mail.gmail.com>
Comments: In-reply-to James Coleman <jtc331@gmail.com>
	message dated "Tue, 31 Mar 2020 13:25:02 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18987.1585677504.1@sss.pgh.pa.us>
Date: Tue, 31 Mar 2020 13:58:24 -0400
Message-ID: <18988.1585677504@sss.pgh.pa.us>
Precedence: bulk

James Coleman <jtc331@gmail.com> writes:
> On Tue, Mar 31, 2020 at 1:04 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Perhaps the semantics are such that that's actually sensible, but it's
>> far from a straightforward remapping of the old enum.

> Right, I didn't see the explicit "= 0" in other enums there, so it
> made me wonder if it was intentional to designate that one had to be
> 0, but I guess without a comment that's a lot of inference.

It's possible that somebody meant that as an indicator that the code
depends on palloc0() leaving the field with that value.  But if so,
you'd soon find that out ... and an actual comment would be better,
anyway.

			regards, tom lane