User-Agent: Cyrus-JMAP/3.5.0-alpha0-533-gf73e617b8a-fm-20210712.002-gf73e617b
Mime-Version: 1.0
Message-Id: <189e4a79-c477-44e0-b3a2-e242b491948d@www.fastmail.com>
In-Reply-To: 
 <CAApHDvpfr07JBykytxDXLxMjtExgmSKRUaR4dXkAt5xaGumUBA@mail.gmail.com>
References: <20210719195950.gavgs6ujzmjfaiig@alap3.anarazel.de>
 <CAApHDvpQQc67NbYJkM0GZWVw_wZvUvOuuANCPiOyobV=q1=owA@mail.gmail.com>
 <20210720061657.bcueir3krgmkt6m5@alap3.anarazel.de>
 <CAApHDvpfr07JBykytxDXLxMjtExgmSKRUaR4dXkAt5xaGumUBA@mail.gmail.com>
Date: Tue, 20 Jul 2021 00:03:51 -0700
From: "Andres Freund" <andres@anarazel.de>
To: "David Rowley" <dgrowleyml@gmail.com>
Cc: "PostgreSQL Development" <pgsql-hackers@postgresql.org>,
 "Robert Haas" <robertmhaas@gmail.com>,
 "Michael Paquier" <michael.paquier@gmail.com>, "Tomas Vondra" <tv@fuzzy.cz>
Subject: 
 =?UTF-8?Q?Re:_Avoid_stack_frame_setup_in_performance_critical_routines_u?=
 =?UTF-8?Q?sing_tail_calls?=
Content-Type: text/plain
Archived-At: 
 <https://www.postgresql.org/message-id/189e4a79-c477-44e0-b3a2-e242b491948d%40www.fastmail.com>
Precedence: bulk

Hi,

On Mon, Jul 19, 2021, at 23:53, David Rowley wrote:
> On Tue, 20 Jul 2021 at 18:17, Andres Freund <andres@anarazel.de> wrote:
> > Any chance you could show a `perf annotate AllocSetAlloc` and `perf annotate
> > palloc` from a patched run? And perhaps how high their percentages of the
> > total work are. E.g. using something like
> > perf report -g none|grep -E 'AllocSetAlloc|palloc|MemoryContextAlloc|pfree'
> 
> Sure. See attached.
> 
> David
> 
> Attachments:
> * AllocateSetAlloc.txt
> * palloc.txt
> * percent.txt

Huh, that's interesting. You have some control flow enforcement stuff turned on (the endbr64). And it looks like it has a non zero cost (or maybe it's just skid). Did you enable that intentionally? If not, what compiler/version/distro is it? I think at least on GCC that's -fcf-protection=...

Andres