Subject: Re: psql - add SHOW_ALL_RESULTS option
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com>
 <20210412193301.GA11204@alvherre.pgsql> <YHeVHH0wVcRwdogL@paquier.xyz>
 <3738387.1618451507@sss.pgh.pa.us>
 <alpine.DEB.2.22.394.2104151336060.191178@pseudo>
 <451a2111-3757-c511-9413-8f8af531a167@enterprisedb.com>
 <alpine.DEB.2.22.394.2106121130400.4105466@pseudo>
 <CALDaNm0+pzGgp-M1mAoUVYRtjadbWYuB96J8RaV9iH3+HA8FTA@mail.gmail.com>
 <alpine.DEB.2.22.394.2107151742300.1705285@pseudo>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com>
Date: Wed, 21 Jul 2021 21:55:30 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2107151742300.1705285@pseudo>
Content-Type: multipart/mixed;
 boundary="------------FF43386A6C9BAF988BB2FC17"
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/18c78a01-4a34-9dd4-f78b-6860f1420c8e%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------FF43386A6C9BAF988BB2FC17
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15.07.21 17:46, Fabien COELHO wrote:
>> The patch does not apply on Head anymore, could you rebase and post a
>> patch. I'm changing the status to "Waiting for Author".
> 
> Ok. I noticed. The patch got significantly broken by the watch pager 
> commit. I also have to enhance the added tests (per Peter request).

I wrote a test to check psql query cancel support.  I checked that it 
fails against the patch that was reverted.  Maybe this is useful.

--------------FF43386A6C9BAF988BB2FC17
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="0001-psql-Add-test-for-query-canceling.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0001-psql-Add-test-for-query-canceling.patch"

RnJvbSA2ZmY2ZjhiMDI0NmNlYTA4YjdlMzI5YTNlNWY0OWNlYzNmODNhNWJjIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogV2VkLCAyMSBKdWwgMjAyMSAyMTo0NjoxMSArMDIwMApTdWJqZWN0
OiBbUEFUQ0hdIHBzcWw6IEFkZCB0ZXN0IGZvciBxdWVyeSBjYW5jZWxpbmcKCi0tLQogc3Jj
L2Jpbi9wc3FsL3QvMDIwX2NhbmNlbC5wbCB8IDMyICsrKysrKysrKysrKysrKysrKysrKysr
KysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKQogY3JlYXRlIG1v
ZGUgMTAwNjQ0IHNyYy9iaW4vcHNxbC90LzAyMF9jYW5jZWwucGwKCmRpZmYgLS1naXQgYS9z
cmMvYmluL3BzcWwvdC8wMjBfY2FuY2VsLnBsIGIvc3JjL2Jpbi9wc3FsL3QvMDIwX2NhbmNl
bC5wbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwLi4wZDU2YjQ3ZmYz
Ci0tLSAvZGV2L251bGwKKysrIGIvc3JjL2Jpbi9wc3FsL3QvMDIwX2NhbmNlbC5wbApAQCAt
MCwwICsxLDMyIEBACit1c2Ugc3RyaWN0OwordXNlIHdhcm5pbmdzOworCit1c2UgUG9zdGdy
ZXNOb2RlOwordXNlIFRlc3RMaWI7Cit1c2UgVGVzdDo6TW9yZSB0ZXN0cyA9PiAyOworCitt
eSAkdGVtcGRpciA9IFRlc3RMaWI6OnRlbXBkaXI7CisKK215ICRub2RlID0gZ2V0X25ld19u
b2RlKCdtYWluJyk7Ciskbm9kZS0+aW5pdDsKKyRub2RlLT5zdGFydDsKKworIyB0ZXN0IHF1
ZXJ5IGNhbmNlbGluZyBieSBzZW5kaW5nIFNJR0lOVCB0byBhIHJ1bm5pbmcgcHNxbAorU0tJ
UDogeworCXNraXAgImNhbmNlbCB0ZXN0IHJlcXVpcmVzIGEgVW5peCBzaGVsbCIsIDIgaWYg
JHdpbmRvd3Nfb3M7CisKKwlsb2NhbCAlRU5WID0gJG5vZGUtPl9nZXRfZW52KCk7CisKKwls
b2NhbCAkU0lHe0FMUk19ID0gc3ViIHsKKwkJbXkgJHBzcWxfcGlkID0gVGVzdExpYjo6c2x1
cnBfZmlsZSgiJHRlbXBkaXIvcHNxbC5waWQiKTsKKwkJa2lsbCAnSU5UJywgJHBzcWxfcGlk
OworCX07CisJYWxhcm0gMTsKKworCW15ICRzdGRpbiA9ICJcXCEgZWNobyBcJFBQSUQgPiR0
ZW1wZGlyL3BzcWwucGlkXG5zZWxlY3QgcGdfc2xlZXAoNSk7IjsKKwlteSAoJHN0ZG91dCwg
JHN0ZGVycik7CisJbXkgJHJlc3VsdCA9IElQQzo6UnVuOjpydW4oWydwc3FsJywgJy12Jywg
J09OX0VSUk9SX1NUT1A9MSddLCAnPCcsIFwkc3RkaW4sICc+JywgXCRzdGRvdXQsICcyPics
IFwkc3RkZXJyKTsKKworCW9rKCEkcmVzdWx0LCAncXVlcnkgZmFpbGVkJyk7CisJbGlrZSgk
c3RkZXJyLCBxci9jYW5jZWxpbmcgc3RhdGVtZW50IGR1ZSB0byB1c2VyIHJlcXVlc3QvLCAn
cXVlcnkgd2FzIGNhbmNlbGVkJyk7Cit9Ci0tIAoyLjMyLjAKCg==
--------------FF43386A6C9BAF988BB2FC17--