Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1j7CGU-00026b-4q
	for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Feb 2020 06:03:18 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1j7CGS-0001zt-Os
	for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Feb 2020 06:03:16 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1j7CGS-0001zj-GQ
	for pgsql-hackers@lists.postgresql.org; Thu, 27 Feb 2020 06:03:16 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1j7CGP-00009n-Rw
	for pgsql-hackers@lists.postgresql.org; Thu, 27 Feb 2020 06:03:16 +0000
Received: from hnk.local (sp49-97-94-11.msc.spmode.ne.jp [49.97.94.11])
	by oss.nttdata.com (Postfix) with ESMTPSA id 58795602D0;
	Thu, 27 Feb 2020 15:03:08 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.101.5 at oss.nttdata.com
Subject: Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.
To: Peter Geoghegan <pg@bowt.ie>,
 Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 =?UTF-8?B?0K7RgNC40Lkg0KHQvtC60L7Qu9C+0LI=?= <funny.falcon@gmail.com>
References: <55E4051B.7020209@postgrespro.ru>
 <5b5a470b-89d7-7177-29c2-2f907f3f441a@iki.fi>
 <CAH2-WzmZGO-NpSCu33tsoZcOskS8UbTUdd7e9V2kJA-kDusWaA@mail.gmail.com>
 <CAH2-Wz=aAMARy08hrzN9UOE4AegsAkge+0nsYk+no2S14W2g2Q@mail.gmail.com>
 <CAH2-Wz=Tr6mxMsKRmv_=9-05_O9QWqOzQ8GweRV2DXS6+Y38QQ@mail.gmail.com>
 <CAH2-Wzme6NA70bkHK=Jrjx+bkHr9DAj9gX+y5OpmvEVNy0eqVQ@mail.gmail.com>
 <CAH2-Wzk42XV2Dg4tYGsLV2X0hf8PSLZ=9gOTOSnp+d6QB_nTyA@mail.gmail.com>
 <CAH2-WzmQGYDDoAETGhpGtJQRv_uFHMjvQZ6JdLV-sxGoCgLBNg@mail.gmail.com>
 <ed6caece-5a64-ad02-2134-1e71fb4b35a1@postgrespro.ru>
 <CAH2-Wzk2p_9i7i-s22zVGdJyExaneNCcrwH4BtEDZqr73D6v_A@mail.gmail.com>
 <ed918743-bf32-b8af-0620-e07c1d81ce2f@postgrespro.ru>
 <CAH2-Wzk8aMGF6ficoKZigjwGw07hPtXdvZjPCrms_tT8GKzG=A@mail.gmail.com>
 <CAH2-Wz=_wt8D4v-1=MfhvWiyevrk+esWgE51tTnBpsOVDwN9Kw@mail.gmail.com>
 <CAH2-Wzmo_zPCs+xC=bWw7SYUtFKXV_uzCjyo-TMp+uWNXghtUQ@mail.gmail.com>
 <CAH2-Wznj6-cY3y=U01oRD4agHDopBfCCcEsWLeu-ojoyPsoPag@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <18f07ae8-7d89-537c-b0a9-54100a1b46da@oss.nttdata.com>
Date: Thu, 27 Feb 2020 15:03:07 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: 
 <CAH2-Wznj6-cY3y=U01oRD4agHDopBfCCcEsWLeu-ojoyPsoPag@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk



On 2020/02/27 7:43, Peter Geoghegan wrote:
> On Mon, Feb 24, 2020 at 4:54 PM Peter Geoghegan <pg@bowt.ie> wrote:
>> Attached is v34, which has this change. My plan is to commit something
>> very close to this on Wednesday morning (barring any objections).
> 
> Pushed.

Thanks for committing this nice feature!

Here is one minor comment.

+      <primary><varname>deduplicate_items</varname></primary>
+      <secondary>storage parameter</secondary>

This should be

     <primary><varname>deduplicate_items</varname> storage parameter</primary>

<secondary> for reloption is necessary only when the GUC parameter
with the same name of the reloption exists. So, for example, you can
see that <secondary> is used in vacuum_cleanup_index_scale_factor
but not in buffering reloption.

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters