Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oviWg-0008RT-Pr
	for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Nov 2022 17:18:10 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oviWf-0008JP-FD
	for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Nov 2022 17:18:09 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oviWf-0008JG-5x
	for pgsql-hackers@lists.postgresql.org; Thu, 17 Nov 2022 17:18:09 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oviWd-00037o-6V
	for pgsql-hackers@lists.postgresql.org; Thu, 17 Nov 2022 17:18:08 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2AHHI0pm1904122;
	Thu, 17 Nov 2022 12:18:00 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Robert Haas <robertmhaas@gmail.com>,
        Melanie Plageman <melanieplageman@gmail.com>,
        Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
        "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
        Nitin Jadhav <nitinjadhavpostgres@gmail.com>,
        Matthias van de Meent <boekewurm+postgres@gmail.com>,
        Ashutosh Sharma <ashu.coek88@gmail.com>,
        Julien Rouhaud <rjuju123@gmail.com>, Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Report checkpoint progress with pg_stat_progress_checkpoint (was:
 Report checkpoint progress in server logs)
In-reply-to: <20221117162431.a3kqnpgjjsa7foxy@awork3.anarazel.de>
References: <20220319001556.atuqbmafvc73pa2k@alap3.anarazel.de>
 <CAMm1aWa_3N1Z2-_YwdNxfogs_rxzpu90VZeKjqwjerCVq9rQAw@mail.gmail.com>
 <20220707000446.hefgyu5xikxwt4md@alap3.anarazel.de>
 <CAMm1aWbfFwT+Cf1eSrXtF2R8ffxXTbH=un8unQ8WbcpcbymnYw@mail.gmail.com>
 <d9546a13-dd86-57d8-3bb4-32136fbb3673@gmail.com>
 <CA+TgmoaJEDirAMq_9q3B8PrXDf1h72S7hhPr4aotakYe9HLoLw@mail.gmail.com>
 <CALj2ACX5xK_X=MSBh_Qe518O7V5D2phnpXuSD9=-zAkGnyo9vA@mail.gmail.com>
 <CA+TgmoYCu6RpuJ3cZz0e7cZSfaVb=cr6iVcgGMGd5dxX0MYNRA@mail.gmail.com>
 <20221116195232.wynvnlng2ivne76b@awork3.anarazel.de>
 <CA+TgmoYJ9qdK6naA2pxMZc+amyNCSRScBg4W-Anqd_8y2oZt0A@mail.gmail.com>
 <20221117162431.a3kqnpgjjsa7foxy@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 17 Nov 2022 08:24:31 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1904119.1668705480.1@sss.pgh.pa.us>
Date: Thu, 17 Nov 2022 12:18:00 -0500
Message-ID: <1904120.1668705480@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/1904120.1668705480%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I think pgstat_progress_start_command() needs the changecount stuff, as does
> pgstat_progress_update_multi_param(). But for anything updating a single
> parameter at a time it really doesn't do anything useful on a platform that
> doesn't tear 64bit writes (so it could be #ifdef
> PG_HAVE_8BYTE_SINGLE_COPY_ATOMICITY).

Seems safe to restrict it to that case.

			regards, tom lane