Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hB4eB-0001cq-UV
	for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 21:39:16 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hB4eA-000101-GI
	for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 21:39:14 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hB4eA-0000wz-4K
	for pgsql-hackers@lists.postgresql.org; Mon, 01 Apr 2019 21:39:14 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hB4e7-0006S8-OR
	for pgsql-hackers@lists.postgresql.org; Mon, 01 Apr 2019 21:39:12 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x31Ld536019056;
	Mon, 1 Apr 2019 17:39:05 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Georgios Kokolatos <gkokolatos@pm.me>,
        PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: CPU costs of random_zipfian in pgbench
In-reply-to: <alpine.DEB.2.21.1903242006310.9939@lancre>
References: <b5e172e9-ad22-48a3-86a3-589afa20e8f7@2ndquadrant.com>
 <alpine.DEB.2.21.1902221716430.4182@lancre>
 <155246731010.16480.15850913449923768119.pgcf@coridan.postgresql.org>
 <alpine.DEB.2.21.1903131048290.4059@lancre> <3703.1553360483@sss.pgh.pa.us>
 <alpine.DEB.2.21.1903231802440.18811@lancre>
 <010a884f-8ffc-4cb7-9773-fd05f32ef4cc@2ndquadrant.com>
 <alpine.DEB.2.21.1903241513570.9939@lancre>
 <alpine.DEB.2.21.1903241823070.9939@lancre> <29040.1553452066@sss.pgh.pa.us>
 <alpine.DEB.2.21.1903242006310.9939@lancre>
Comments: In-reply-to Fabien COELHO <coelho@cri.ensmp.fr>
	message dated "Sun, 24 Mar 2019 21:21:45 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19054.1554154745.1@sss.pgh.pa.us>
Date: Mon, 01 Apr 2019 17:39:05 -0400
Message-ID: <19055.1554154745@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> I was wondering about that too.  It seems like it'd be a wise idea to
>> further constrain s and/or n to ensure that the s > 1 code path doesn't do
>> anything too awful ...

> Yep. The attached version enforces s >= 1.001, which avoids the worse cost
> of iterating, according to my small tests.

Seems reasonable.  Pushed with minor documentation editing.

			regards, tom lane