From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
In-reply-to: <ff1b26a3-7f36-474a-93f1-bb9afcc7cf87@eisentraut.org>
References: <aa73q1aT0A3/vke/@ip-10-97-1-34.eu-west-3.compute.internal>
 <44885d54-0376-46b3-b574-59e0e3098580@eisentraut.org>
 <dfb1373e-258f-42b7-ac76-0f5858936dfa@eisentraut.org>
 <4ab608af-2f90-47d8-88a5-6329f6630fff@eisentraut.org>
 <acI6X6YmtHnEURKL@ip-10-97-1-34.eu-west-3.compute.internal>
 <ff1b26a3-7f36-474a-93f1-bb9afcc7cf87@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Fri, 27 Mar 2026 08:38:45 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1912637.1775510391.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 06 Apr 2026 17:19:51 -0400
Message-ID: <1912638.1775510391@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1912638.1775510391%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> The first three patches have been committed.

b4a132022 has had some not-so-desirable effects in the buildfarm:
drongo and hoatzin are each spewing a couple dozen repetitive
warnings about every bison-generated header file, eg

src/backend/bootstrap/bootparse.h(111): warning C4255: 'boot_yyparse': no =
function prototype given: converting '()' to '(void)'

Both of those machines are using bison 2.7, which is pretty old
and evidently isn't careful about generating complete prototypes.

I'm not sure if there's anything to be done about this, except
perhaps nag the animals' owners to find a newer bison somewhere.
We could revert b4a132022, but then we might miss valid warnings
about such issues in Windows-only code.

			regards, tom lane