Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfFx1-0004eO-Ni for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Oct 2021 06:28:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mfFx0-0002Fb-DI for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Oct 2021 06:28:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mfFx0-0002EZ-3y for pgsql-hackers@lists.postgresql.org; Tue, 26 Oct 2021 06:28:46 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mfFwu-0008J4-To for pgsql-hackers@lists.postgresql.org; Tue, 26 Oct 2021 06:28:44 +0000 Received: by mail-wm1-x335.google.com with SMTP id j2-20020a1c2302000000b0032ca9b0a057so1060252wmj.3 for ; Mon, 25 Oct 2021 23:28:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aiven.io; s=google; h=from:to:cc:subject:date:message-id:organization:in-reply-to :references:mime-version:content-transfer-encoding; bh=r+cWWUb3mN/urSqQxH6Pv9TJK1adWwYIvYdnDvHGmzc=; b=IKLydEOAgst/t12HBXo9bmNr8Rc495e5eFKtari9bLtbTcNnsq3KIibEYWAspL3L1Z /wQtBQNjXqU/Cz42fbJmutt4agwMmR3Q8fOvGod2vu2DrR0ZwyWWIDtBHaCoERON1AY2 NX+u94I/M7YJld3Wd/jsoR1TN8VtO4gujlhc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :in-reply-to:references:mime-version:content-transfer-encoding; bh=r+cWWUb3mN/urSqQxH6Pv9TJK1adWwYIvYdnDvHGmzc=; b=WgzBkdDqh4iJpO8U8Q8X//UyFwPmaFA/+umJIyghZXyL4hv8SeYL0FLmNeZvflpGyD Vy5izakg4sGzBAC9d6uZEZZWKG8qoDP6tzm7DKV5rmBD0xfSOGBk6IRuqOxYyGnYi0Ie KLNYHATp/pbZKVN+/o2gIbPxzQSL+JyfmA3mW8u2T4P5EEIjcho9TTQ+5EyA+JR4dbVv ldCG10fBKgPOtxvqguZFRQFSd7sXxLf56Z3UeswCeetwPsUAxgyo0GfqWEklKWwIPZRf W6mX7DTNjSeCS06GtfJtnk3i6UrteHeR3HBpdVE01LS98LgVU6AniJsVL+S7zZWM6rTT KNww== X-Gm-Message-State: AOAM533QLmNKSzfRmN7euRf7FhKWxkj4HYOtJk7XOE+bVJ68aA97FpNZ Sgm0pXkqaga3JydGtIOXsgcSKg== X-Google-Smtp-Source: ABdhPJxx4HwftUv+Pwtof1RJexJDJGXswAB8W5m9JY4xo/LtcQTNpP5VMK0krYl/vAOvyMGRDpqjFw== X-Received: by 2002:a05:600c:2310:: with SMTP id 16mr26218458wmo.157.1635229719558; Mon, 25 Oct 2021 23:28:39 -0700 (PDT) Received: from aivenronan.localnet (static-176-158-121-96.ftth.abo.bbox.fr. [176.158.121.96]) by smtp.gmail.com with ESMTPSA id x8sm13030116wrw.6.2021.10.25.23.28.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 23:28:39 -0700 (PDT) From: Ronan Dunklau To: Bharath Rupireddy , Michael Paquier Cc: PostgreSQL Hackers , Kyotaro Horiguchi , Masahiko Sawada Subject: Re: pg_receivewal starting position Date: Tue, 26 Oct 2021 08:27:47 +0200 Message-ID: <1914572.usQuhbGJ8B@aivenronan> Organization: aiven In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Le mardi 26 octobre 2021, 03:15:40 CEST Michael Paquier a =E9crit : > I have changed the patch per Ronan's suggestion to have the version > check out of GetSlotInformation(), addressed what you have reported, > and the result looked good. So I have applied this part. Thanks ! >=20 > What remains on this thread is the addition of new tests to make sure > that pg_receivewal is able to follow a timeline switch. Now that we > can restart from a slot that should be a bit easier to implemented as > a test by creating a slot on a standby. Ronan, are you planning to > send a new patch for this part? Yes, I will try to simplify the logic of the patch I sent last week. I'll k= eep=20 you posted here soon. =2D-=20 Ronan Dunklau