Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9rY5-001ppT-2j for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Apr 2026 21:31:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w9rY3-00CBjt-2I for pgsql-hackers@arkaria.postgresql.org; Mon, 06 Apr 2026 21:31:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w9rY3-00CBjk-1M for pgsql-hackers@lists.postgresql.org; Mon, 06 Apr 2026 21:31:55 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w9rY1-00000000yB9-0jWk for pgsql-hackers@postgresql.org; Mon, 06 Apr 2026 21:31:55 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 636LVnH81914807; Mon, 6 Apr 2026 17:31:49 -0400 From: Tom Lane To: Peter Eisentraut cc: Jelte Fennema-Nio , pgsql-hackers Subject: Re: enable fallthrough warnings on clang In-reply-to: References: <76a8efcd-925a-4eaf-bdd1-d972cd1a32ff@eisentraut.org> <955ddaa3-d6e8-4d87-a368-ef9f25960d4e@eisentraut.org> Comments: In-reply-to Peter Eisentraut message dated "Mon, 23 Feb 2026 08:32:34 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1914805.1775511109.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 06 Apr 2026 17:31:49 -0400 Message-ID: <1914806.1775511109@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > I have committed this patch set. I also added a test into the C++ modul= e. BF member ayu is failing said test: ccache clang++-4.0 -std=3Dgnu++11 -Wall -Wpointer-arith -Werror=3Dvla -Wmi= ssing-format-attribute -Wimplicit-fallthrough -Wformat-security -fno-stric= t-aliasing -fwrapv -g -O2 -fPIC -fvisibility=3Dhidden -fvisibility-inlines= -hidden -I. -I. -I../../../../src/include -D_GNU_SOURCE -I/usr/include/li= bxml2 -c -o test_cplusplusext.o test_cplusplusext.cpp test_cplusplusext.cpp:66:3: warning: unannotated fall-through between swit= ch labels [-Wimplicit-fallthrough] case 2: ^ test_cplusplusext.cpp:66:3: note: insert '[[clang::fallthrough]];' to sile= nce this warning case 2: ^ [[clang::fallthrough]]; = test_cplusplusext.cpp:66:3: note: insert 'break;' to avoid fall-through case 2: ^ break; = 1 warning generated. I don't know if it's worth catering to this extremely old clang version ... regards, tom lane