Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jK2Vo-0007IP-PP
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Apr 2020 16:16:12 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jK2Vn-0003dH-Dl
	for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Apr 2020 16:16:11 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jK2Vn-0003bI-6g
	for pgsql-hackers@lists.postgresql.org; Thu, 02 Apr 2020 16:16:11 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jK2Vj-0004UY-A5
	for pgsql-hackers@lists.postgresql.org; Thu, 02 Apr 2020 16:16:10 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 032GG39X019152;
	Thu, 2 Apr 2020 12:16:03 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nikita Glukhov <n.gluhov@postgrespro.ru>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Dmitry Belyavsky <beldmit@gmail.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Thomas Munro <thomas.munro@gmail.com>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Nikolay Shaplov <dhyan@nataraj.su>
Subject: Re: Ltree syntax improvement
In-reply-to: <ef4ae519-2b65-c7f0-00d2-3dffe6d04f0d@postgrespro.ru>
References: 
 <CADqLbzLS1dy9TARVBYR=E+HUwjrAqZAoakFp_vTKWFJK=XF3Rg@mail.gmail.com>
 <20190708203303.GA17993@alvherre.pgsql>
 <CADqLbzKZ0jEEiV2mvFs3LfjfghGX9-goybbFVgUNGyqDu=rg4w@mail.gmail.com>
 <CA+hUKG+G7fP-t43ptqkBw9aW2zQuazN2g_U9yCX6dN9E65u4tw@mail.gmail.com>
 <CADqLbzKCh2e-nOyAtCX4GqW+HbwD4yX=wuOMMRFGtRYWgcnMeg@mail.gmail.com>
 <f2aa520a-f987-e03d-33cc-8aac52511332@postgrespro.ru>
 <CA+hUKGLMS_bjeT1T7g5wT+rJQb8EUcW0HDtUbCueXTmBJ9Z9UA@mail.gmail.com>
 <20200106134933.u2rblkj7ec4jky6u@development>
 <CADqLbzKRP0Dgb4oYKAE1za=7aKiATiyKrsGZ0AAVq9GE5H=eBg@mail.gmail.com>
 <31385.1579634002@sss.pgh.pa.us>
 <38c5bbeb-c3eb-a016-0b8f-907461bbd0fc@postgrespro.ru>
 <14141.1585091295@sss.pgh.pa.us>
 <a066844c-5546-b9fe-c776-bf17bd26bf82@postgrespro.ru>
 <8570.1585784810@sss.pgh.pa.us>
 <ef4ae519-2b65-c7f0-00d2-3dffe6d04f0d@postgrespro.ru>
Comments: In-reply-to Nikita Glukhov <n.gluhov@postgrespro.ru>
	message dated "Thu, 02 Apr 2020 16:16:06 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <19150.1585844163.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 02 Apr 2020 12:16:03 -0400
Message-ID: <19151.1585844163@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Nikita Glukhov <n.gluhov@postgrespro.ru> writes:
> Rebased patch attached.

Thanks for rebasing!  The cfbot's not very happy though:

4842ltxtquery_io.c: In function =E2=80=98makepol=E2=80=99:
4843ltxtquery_io.c:188:13: error: =E2=80=98escaped=E2=80=99 may be used un=
initialized in this function [-Werror=3Dmaybe-uninitialized]
4844  if (lenval - escaped <=3D 0)
4845             ^
4846ltxtquery_io.c:230:6: note: =E2=80=98escaped=E2=80=99 was declared her=
e
4847  int   escaped;
4848      ^
4849cc1: all warnings being treated as errors

			regards, tom lane