Received: from maia.hub.org (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 452D3632F37 for ; Sat, 24 Apr 2010 23:28:14 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 01272-02 for ; Sun, 25 Apr 2010 02:27:54 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 986AB632A64 for ; Sat, 24 Apr 2010 23:28:03 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id o3P2S0li019199; Sat, 24 Apr 2010 22:28:00 -0400 (EDT) To: Robert Haas cc: Jim Nasby , Greg Sabino Mullane , pgsql-hackers@postgresql.org Subject: Re: global temporary tables In-reply-to: References: <7796.1272125493@sss.pgh.pa.us> <9319.1272130283@sss.pgh.pa.us> <18126.1272159451@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Sat, 24 Apr 2010 22:22:58 -0400" Date: Sat, 24 Apr 2010 22:28:00 -0400 Message-ID: <19198.1272162480@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.105 tagged_above=-10 required=5 tests=AWL=-0.195, BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201004/1145 X-Sequence-Number: 161257 Robert Haas writes: > Oh, maybe I do see. If we pass it to smgropen() and stash it in the > SMgrRelation, we don't have to keep supplying it later on, maybe? Right. I'm unsure whether we should push it into the RelFileNode struct itself, but even having it in SMgrRelation ought to cut out a few places where it now has to be passed separately. regards, tom lane