Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <20240509193425.GA3219615@nathanxps13>
Date: Thu, 9 May 2024 21:58:37 +0200
Cc: Michael Paquier <michael@paquier.xyz>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter@eisentraut.org>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: 7bit
Message-Id: <191F8200-688E-4B70-8B45-B3DD1BBF11B9@yesql.se>
References: <20240503171348.GA1731524@nathanxps13>
 <677ed9ca-8653-4c27-80ca-0ea763f0f21f@eisentraut.org>
 <20240508183850.GA2824188@nathanxps13> <818511.1715194198@sss.pgh.pa.us>
 <ZjwS7KMcRq7YGvt5@paquier.xyz> <20240509193425.GA3219615@nathanxps13>
To: Nathan Bossart <nathandbossart@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/191F8200-688E-4B70-8B45-B3DD1BBF11B9%40yesql.se>
Precedence: bulk

> On 9 May 2024, at 21:34, Nathan Bossart <nathandbossart@gmail.com> wrote:
> 
> On Thu, May 09, 2024 at 09:03:56AM +0900, Michael Paquier wrote:
>> +1.  Could there be an argument in favor of a backpatch?  This is a
>> performance improvement, but one could also side that the addition of
>> sync support in pg_dump[all] has made that a regression that we'd
>> better fix because the flushes don't matter in this context.  They
>> also bring costs for no gain.
> 
> I don't see a strong need to back-patch this, if for no other reason than
> it seems to have gone unnoticed for 7 major versions.  Plus, based on my
> admittedly limited testing, this is unlikely to provide significant
> improvements.

Agreed, this is a nice little improvement but it's unlikely to be enough of a
speedup to warrant changing the backbranches.

--
Daniel Gustafsson