From: Tom Lane <tgl@sss.pgh.pa.us>
To: rmrodriguez@carto.com
cc: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Optimze usage of immutable functions as relation
In-reply-to: 
 <CAM6_UM4isP+buRA5sWodO_MUEgutms-KDfnkwGmryc5DGj9XuQ@mail.gmail.com>
References: <402356c32eeb93d4fed01f66d6c7fe2d@postgrespro.ru>
 <20180906185109.661aaef0@asp437-ThinkPad-L380>
 <153994199621.10161.17815885396545049364.pgcf@coridan.postgresql.org>
 <CACdpekK1oDy7-_HnXOaREa_8HM2r-fsp8iv5e6p8aWOdGdK8Mg@mail.gmail.com>
 <2906.1542395026@sss.pgh.pa.us>
 <3f7fda2f-1cdc-8ad3-e3c9-c2436fb5d509@postgrespro.ru>
 <CA+hUKGK1ATcNa678n=AG+DHQrFmWr-Lovmsq2AP-m5r=shW0Mg@mail.gmail.com>
 <0dd4efb2-22a3-6fef-11f7-1b20dd71a509@postgrespro.ru>
 <d31c5077-398f-dd26-ef9f-df11918b42f0@postgrespro.ru>
 <18924.1564165560@sss.pgh.pa.us>
 <18cbbbf6-5c03-41d5-5bd4-30048c2e5155@postgrespro.ru>
 <24410.1564700236@sss.pgh.pa.us>
 <CAM6_UM4isP+buRA5sWodO_MUEgutms-KDfnkwGmryc5DGj9XuQ@mail.gmail.com>
Comments: In-reply-to rmrodriguez@carto.com
	message dated "Tue, 24 Sep 2019 13:39:20 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19227.1569338231.1@sss.pgh.pa.us>
Date: Tue, 24 Sep 2019 11:17:11 -0400
Message-ID: <19228.1569338231@sss.pgh.pa.us>
Precedence: bulk

rmrodriguez@carto.com writes:
> This commit is breaking some Postgis tests with custom types.

Hm, yeah, the code fails to consider the possibility that the function
returns a composite type.

For the moment I'm just going to make it punt if the function result
class isn't TYPEFUNC_SCALAR.  In principle, if we have a composite
result, we could disassemble it into per-column constant values, but
I'm not sure it'd be worth the work.

			regards, tom lane