From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Noah Misch <noah@leadboat.com>, Andrew Dunstan <andrew@dunslane.net>,
        Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>,
        Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <20230204113453.vmtnayjvhyg5qqqy@alap3.anarazel.de>
References: <CAH2-WzkHHcPRMj3G1b_dUfY0aR4W4OAHQ9_Z6sDGvL8Ew+aRrA@mail.gmail.com> <20230121224312.qmwpagrebidr6hi7@awork3.anarazel.de> <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com> <20230122094957.x542ojaqgi4lalq4@awork3.anarazel.de> <CAGECzQRYjHdNQ-Bq2yrBb-8s3Pjx7pfvYPDdNv9tcvDcscDhbg@mail.gmail.com> <20230122223806.3sgew6qswhsczae7@awork3.anarazel.de> <1489276.1674427657@sss.pgh.pa.us> <de0a7034-0186-1f91-b408-eb67f2a854dc@dunslane.net> <1708030.1675446770@sss.pgh.pa.us> <20230204041848.GC1896331@rfd.leadboat.com> <20230204113453.vmtnayjvhyg5qqqy@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 04 Feb 2023 03:34:53 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1923920.1675526879.1@sss.pgh.pa.us>
Date: Sat, 04 Feb 2023 11:07:59 -0500
Message-ID: <1923921.1675526879@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1923921.1675526879%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> ISTM that we're closer to being able to enforce pgindent than
> perltidy. At the same time, I think the issue of C code in HEAD not
> being indented is more pressing - IME it's much more common to have to
> touch a lot of C code than to have to touch a lot fo perl files.  So
> perhaps we should just start with being more stringent with C code, and
> once we made perltidy less noisy, add that?

Agreed, we should move more slowly with perltidy.  Aside from the
points you raise, I bet fewer committers have it installed at all.

(I haven't forgotten that I'm on the hook to import pg_bsd_indent
into our tree.  Will get to that soon.)

			regards, tom lane