Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jXYdc-0001HY-4i
	for pgsql-hackers@arkaria.postgresql.org; Sat, 09 May 2020 23:12:08 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1jXYda-0007wF-Vr
	for pgsql-hackers@arkaria.postgresql.org; Sat, 09 May 2020 23:12:06 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jXYda-0007tw-Oz
	for pgsql-hackers@lists.postgresql.org; Sat, 09 May 2020 23:12:06 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jXYdV-0008DU-RE
	for pgsql-hackers@postgresql.org; Sat, 09 May 2020 23:12:04 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 049NBuDk019296;
	Sat, 9 May 2020 19:11:57 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@postgresql.org
Subject: Re: Add -Wold-style-definition to CFLAGS?
In-reply-to: <20200509184354.hpkxuvip64nlnqve@alap3.anarazel.de>
References: <20200509174820.g4bwftmz7blz35ph@alap3.anarazel.de>
 <4838.1589048101@sss.pgh.pa.us>
 <20200509184354.hpkxuvip64nlnqve@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 09 May 2020 11:43:54 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19294.1589065916.1@sss.pgh.pa.us>
Date: Sat, 09 May 2020 19:11:56 -0400
Message-ID: <19295.1589065916@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2020-05-09 14:15:01 -0400, Tom Lane wrote:
>> Andres Freund <andres@anarazel.de> writes:
>>> Since gcc has a warning detecting such definition, I think we ought to
>>> automatically add it when available?

>> +1

> Any opinion about waiting for branching or not?

I'd be OK with pushing it now, but I dunno about other people.

If we do want to push this sort of thing now, the nearby changes
to enable fallthrough warnings should go in too.

			regards, tom lane