X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org Received: from localhost (mx2.hub.org [200.46.204.254]) by postgresql.org (Postfix) with ESMTP id 3E81911F675F for ; Thu, 20 Apr 2006 13:07:49 -0300 (ADT) X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Score: -2.371 X-Spam-Level: X-Spam-Status: No, score=-2.371 required=5 tests=[AWL=0.230, BAYES_00=-2.599, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] Received: from postgresql.org ([200.46.204.71]) by localhost (mx2.hub.org [200.46.204.254]) (amavisd-new, port 10024) with ESMTP id AlnCHNJqnz0L for ; Thu, 20 Apr 2006 13:07:40 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey- Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 38F3F11F6D1F for ; Thu, 20 Apr 2006 13:07:38 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.6/8.13.6) with ESMTP id k3KG7aiF019297; Thu, 20 Apr 2006 12:07:37 -0400 (EDT) To: "Magnus Hagander" cc: "Peter Eisentraut" , pgsql-hackers@postgresql.org, "Yoshiyuki Asaba" Subject: Re: pg_dump -Ft failed on Windows XP In-reply-to: <6BCB9D8A16AC4241919521715F4D8BCEA352D7@algol.sollentuna.se> References: <6BCB9D8A16AC4241919521715F4D8BCEA352D7@algol.sollentuna.se> Comments: In-reply-to "Magnus Hagander" message dated "Thu, 20 Apr 2006 17:50:37 +0200" Date: Thu, 20 Apr 2006 12:07:36 -0400 Message-ID: <19296.1145549256@sss.pgh.pa.us> From: Tom Lane X-Archive-Number: 200604/735 X-Sequence-Number: 82458 "Magnus Hagander" writes: > Ok. Should be easy enough once the code is fine - can you comment on the > patch as sent, if the code itself looks right provided i wrap it up in a > function in port/? Not sure if the error handling is adequate --- are there any cases besides EEXIST that should loop? A look at http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/_crt__tempnam.2c_._wtempnam.2c_.tmpnam.2c_._wtmpnam.asp suggests that tempnam() is also pretty fragile, esp. if you're passing NULLs. Apparently it won't work at all if TMP isn't set? regards, tom lane