Content-Type: multipart/mixed; boundary="------------17VH6nF4LIje0XGorwsTwupz"
Message-ID: <192a2107-7e37-64d6-c5b3-c45448ba2e9e@oss.nttdata.com>
Date: Mon, 22 Nov 2021 11:47:03 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.0
Subject: Re: issue in pgfdw_report_error()?
Content-Language: en-US
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <477c16c8-7ea4-20fc-38d5-ed3a77ed616c@oss.nttdata.com>
 <CALj2ACVt7HcH+qD7e-grw34eyfV6+WwZYE82--rwOik==1wWBg@mail.gmail.com>
 <41aae5d4-4d11-85f6-8f32-1bb5349ce959@oss.nttdata.com>
 <CALj2ACVwi4jSh-4A-Kny8M6bOsypLpi8dNycEtVg4S2qsBDAfQ@mail.gmail.com>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: 
 <CALj2ACVwi4jSh-4A-Kny8M6bOsypLpi8dNycEtVg4S2qsBDAfQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/192a2107-7e37-64d6-c5b3-c45448ba2e9e%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------17VH6nF4LIje0XGorwsTwupz
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2021/11/20 1:16, Bharath Rupireddy wrote:
> With the existing code, it emits "" for message_primary[0] == '\0'
> cases but with the patch it emits "could not obtain message string for
> remote error".

Yes.


> Well, in that case, why can't we get rid of "(message_primary != NULL"
> and just have "message_primary[0] != '\0' ? errmsg_internal("%s",
> message_primary) : errmsg("could not obtain message string for remote
> error")" ?

That's possible if we can confirm that PQerrorMessage() never returns
NULL all the cases. I'm not sure how much it's worth doing that, though..
It seems more robust to check also NULL there.


> BTW, we might have to fix it in dblink_res_error too?

Yeah, that's good idea. I included that change in the patch. Attached.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
--------------17VH6nF4LIje0XGorwsTwupz
Content-Type: text/plain; charset=UTF-8; name="pgfdw_report_error_v2.patch"
Content-Disposition: attachment; filename="pgfdw_report_error_v2.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2NvbnRyaWIvZGJsaW5rL2RibGluay5jIGIvY29udHJpYi9kYmxpbmsv
ZGJsaW5rLmMKaW5kZXggYzhiMGI0ZmYzZi4uZDczYzYxNmY0ZiAxMDA2NDQKLS0tIGEvY29u
dHJpYi9kYmxpbmsvZGJsaW5rLmMKKysrIGIvY29udHJpYi9kYmxpbmsvZGJsaW5rLmMKQEAg
LTI4MDEsNyArMjgwMSw4IEBAIGRibGlua19yZXNfZXJyb3IoUEdjb25uICpjb25uLCBjb25z
dCBjaGFyICpjb25uYW1lLCBQR3Jlc3VsdCAqcmVzLAogCiAJZXJlcG9ydChsZXZlbCwKIAkJ
CShlcnJjb2RlKHNxbHN0YXRlKSwKLQkJCSBtZXNzYWdlX3ByaW1hcnkgPyBlcnJtc2dfaW50
ZXJuYWwoIiVzIiwgbWVzc2FnZV9wcmltYXJ5KSA6CisJCQkgKG1lc3NhZ2VfcHJpbWFyeSAh
PSBOVUxMICYmIG1lc3NhZ2VfcHJpbWFyeVswXSAhPSAnXDAnKSA/CisJCQkgZXJybXNnX2lu
dGVybmFsKCIlcyIsIG1lc3NhZ2VfcHJpbWFyeSkgOgogCQkJIGVycm1zZygiY291bGQgbm90
IG9idGFpbiBtZXNzYWdlIHN0cmluZyBmb3IgcmVtb3RlIGVycm9yIiksCiAJCQkgbWVzc2Fn
ZV9kZXRhaWwgPyBlcnJkZXRhaWxfaW50ZXJuYWwoIiVzIiwgbWVzc2FnZV9kZXRhaWwpIDog
MCwKIAkJCSBtZXNzYWdlX2hpbnQgPyBlcnJoaW50KCIlcyIsIG1lc3NhZ2VfaGludCkgOiAw
LApkaWZmIC0tZ2l0IGEvY29udHJpYi9wb3N0Z3Jlc19mZHcvY29ubmVjdGlvbi5jIGIvY29u
dHJpYi9wb3N0Z3Jlc19mZHcvY29ubmVjdGlvbi5jCmluZGV4IDRhZmYzMTViN2MuLjVjMDEz
NzIyMGEgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvcG9zdGdyZXNfZmR3L2Nvbm5lY3Rpb24uYwor
KysgYi9jb250cmliL3Bvc3RncmVzX2Zkdy9jb25uZWN0aW9uLmMKQEAgLTgyNCw3ICs4MjQs
OCBAQCBwZ2Zkd19yZXBvcnRfZXJyb3IoaW50IGVsZXZlbCwgUEdyZXN1bHQgKnJlcywgUEdj
b25uICpjb25uLAogCiAJCWVyZXBvcnQoZWxldmVsLAogCQkJCShlcnJjb2RlKHNxbHN0YXRl
KSwKLQkJCQkgbWVzc2FnZV9wcmltYXJ5ID8gZXJybXNnX2ludGVybmFsKCIlcyIsIG1lc3Nh
Z2VfcHJpbWFyeSkgOgorCQkJCSAobWVzc2FnZV9wcmltYXJ5ICE9IE5VTEwgJiYgbWVzc2Fn
ZV9wcmltYXJ5WzBdICE9ICdcMCcpID8KKwkJCQkgZXJybXNnX2ludGVybmFsKCIlcyIsIG1l
c3NhZ2VfcHJpbWFyeSkgOgogCQkJCSBlcnJtc2coImNvdWxkIG5vdCBvYnRhaW4gbWVzc2Fn
ZSBzdHJpbmcgZm9yIHJlbW90ZSBlcnJvciIpLAogCQkJCSBtZXNzYWdlX2RldGFpbCA/IGVy
cmRldGFpbF9pbnRlcm5hbCgiJXMiLCBtZXNzYWdlX2RldGFpbCkgOiAwLAogCQkJCSBtZXNz
YWdlX2hpbnQgPyBlcnJoaW50KCIlcyIsIG1lc3NhZ2VfaGludCkgOiAwLAo=
--------------17VH6nF4LIje0XGorwsTwupz--