From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
cc: Michael Paquier <michael@paquier.xyz>,
        Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
        Quan Zongliang <quanzongliang@yeah.net>, pgsql-hackers@postgresql.org
Subject: Re: bugfix: when the blocksize is 32k,
 the function page_header of pageinspect returns negative numbers.
In-reply-to: <20210708042806.GA22043@telsasoft.com>
References: <8b8ec36e-61fe-14f9-005d-07bc85aa4eed@yeah.net>
 <CALj2ACVvmn7RsV9BmXLKv9M-7WZtabyyALECsY_iKbz4Cj1VtA@mail.gmail.com>
 <YOZ70IxyhdGzn6OE@paquier.xyz> <20210708042806.GA22043@telsasoft.com>
Comments: In-reply-to Justin Pryzby <pryzby@telsasoft.com>
	message dated "Wed, 07 Jul 2021 23:28:06 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1932990.1625719765.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 08 Jul 2021 00:49:25 -0400
Message-ID: <1932991.1625719765@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1932991.1625719765%40sss.pgh.pa.us>
Precedence: bulk

Justin Pryzby <pryzby@telsasoft.com> writes:
> On Thu, Jul 08, 2021 at 01:15:12PM +0900, Michael Paquier wrote:
>> Changes in the object set of an extension requires a new SQL script
>> that changes the objects to reflect the change.  So, in this case,
>> what you need to do is to create pageinspect--1.9--1.10.sql, assuming
>> that the new extension version is 1.10 and change page_header()
>> accordingly.

> I think it's common (and preferred) for changes in extension versions to=
 be
> "folded" together within a major release of postgres.  Since v1.9 is new=
 in
> pg14 (commit 756ab2912), this change can be included in the same, new ve=
rsion.

Since we're already past beta2, I'm not sure that's a good idea.  We
can't really treat pageinspect 1.9 as something that the world has
never seen.

			regards, tom lane