MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 23 Sep 2020 15:48:15 +0900
From: Katsuragi Yuta <btkatsuragiyu@oss.nttdata.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add features to pg_stat_statements
In-Reply-To: 
 <CAOBaU_bYknq5in+fp9m8ufQPGq+O82Sk-UKPjfz9P4fFUBA36Q@mail.gmail.com>
References: <0d9f1107772cf5c3f954e985464c7298@oss.nttdata.com>
 <CAOBaU_bYknq5in+fp9m8ufQPGq+O82Sk-UKPjfz9P4fFUBA36Q@mail.gmail.com>
Message-ID: <193879cdb9f6e14060bde2172f8399c9@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.1.9
Precedence: bulk

On 2020-09-18 18:49, Julien Rouhaud wrote:
> Did you consider also adding the cumulated number of
> evicted entries?  This could be useful to know how to configure
> pg_stat_statements.max.

Thank you for your comments!
I overlooked the cumulated number of evicted entries.
This statistic looks important. But, I am not sure
if I should add this statistic to a view.
This is because I am not sure how to utilize the cumulated
number of evicted entries for configuring pg_stat_statements.max.

Not only providing a view but also logging evictions
along with the number of evicted entries might be a choice.
This idea is from legrand legrand [1].

[1] 
https://www.postgresql.org/message-id/1600500942767-0.post%40n3.nabble.com

Regards,
Katsuragi Yuta