Date: Thu, 05 Dec 2024 18:38:16 +0530
From: Srinath Reddy Sadipiralla <srinath.reddy@zohocorp.com>
To: "pgsql-hackers" <pgsql-hackers@lists.postgresql.org>,
	"pgsql" <pgsql@j-davis.com>
Message-Id: <19396ef77f8.1098c4a1810508.2255483659262451647@zohocorp.com>
In-Reply-To: 
Subject: Why we need to check for local buffers in BufferIsExclusiveLocked
 and BufferIsDirty?
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_36279_1800374092.1733404096504"
Importance: Medium
User-Agent: Zoho Mail
Archived-At: <https://www.postgresql.org/message-id/19396ef77f8.1098c4a1810508.2255483659262451647%40zohocorp.com>
Precedence: bulk

------=_Part_36279_1800374092.1733404096504
Content-Type: multipart/alternative; 
	boundary="----=_Part_36280_1397964923.1733404096504"

------=_Part_36280_1397964923.1733404096504
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Why we need to check for local buffers in BufferIsExclusiveLocked and Buffe=
rIsDirty?,these 2 functions are called only from XlogRegisterBuffer,AFAIK w=
hich will be called only for permanent relations.Please correct me if i am =
wrong.

Regards,
Srinath Reddy Sadipiralla
Member of Technical Staff
Zoho
=C2=A0
------=_Part_36280_1397964923.1733404096504
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: 7bit

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head><meta content="text/html;charset=UTF-8" http-equiv="Content-Type"></head><body ><div style="font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 10pt;"><div>Hi,<br><br>Why we need to check for local buffers in BufferIsExclusiveLocked and BufferIsDirty?,these 2 functions are called only from XlogRegisterBuffer,AFAIK which will be called only for permanent relations.Please correct me if i am wrong.<br><br>Regards,<br>Srinath Reddy Sadipiralla<br>Member of Technical Staff<br>Zoho</div><div>&nbsp;<br></div></div><br></body></html>
------=_Part_36280_1397964923.1733404096504--

------=_Part_36279_1800374092.1733404096504
Content-Type: application/octet-stream; 
	name=0001-Ref-remove-local-buffer-checks.patch
Content-Transfer-Encoding: 7bit
X-ZM_AttachId: 139526968965050090
Content-Disposition: attachment; 
	filename=0001-Ref-remove-local-buffer-checks.patch

From 1025dd8faf6e83a24670188159f035667ec8ceb4 Mon Sep 17 00:00:00 2001
From: Srinath Reddy Sadipiralla <srinath.reddy@zohocorp.com>
Date: Thu, 5 Dec 2024 18:12:15 +0530
Subject: [PATCH] [Ref] remove local buffer checks

---
 src/backend/storage/buffer/bufmgr.c | 22 ++--------------------
 1 file changed, 2 insertions(+), 20 deletions(-)

diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 6181673095..8eb1fb63d7 100644
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -2460,16 +2460,7 @@ BufferIsExclusiveLocked(Buffer buffer)
 {
 	BufferDesc *bufHdr;
 
-	if (BufferIsLocal(buffer))
-	{
-		int			bufid = -buffer - 1;
-
-		bufHdr = GetLocalBufferDescriptor(bufid);
-	}
-	else
-	{
-		bufHdr = GetBufferDescriptor(buffer - 1);
-	}
+	bufHdr = GetBufferDescriptor(buffer - 1);
 
 	Assert(BufferIsPinned(buffer));
 	return LWLockHeldByMeInMode(BufferDescriptorGetContentLock(bufHdr),
@@ -2489,16 +2480,7 @@ BufferIsDirty(Buffer buffer)
 {
 	BufferDesc *bufHdr;
 
-	if (BufferIsLocal(buffer))
-	{
-		int			bufid = -buffer - 1;
-
-		bufHdr = GetLocalBufferDescriptor(bufid);
-	}
-	else
-	{
-		bufHdr = GetBufferDescriptor(buffer - 1);
-	}
+	bufHdr = GetBufferDescriptor(buffer - 1);
 
 	Assert(BufferIsPinned(buffer));
 	Assert(LWLockHeldByMeInMode(BufferDescriptorGetContentLock(bufHdr),
-- 
2.39.3 (Apple Git-146)


------=_Part_36279_1800374092.1733404096504--