From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mankirat Singh <mankiratsingh1315@gmail.com>
cc: "David E. Wheeler" <david@justatheory.com>, nathandbossart@gmail.com,
        pg@bowt.ie, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Subject: Re: abi-compliance-check failure due to recent changes to
 pg_{clear,restore}_{attribute,relation}_stats()
In-reply-to: 
 <CAOtk82QCHhWwO=zB-KFYch3JLf8Si4Bk77R_0cgsHjkwuhR9Vg@mail.gmail.com>
References: <aPJ03E2itovDBcKX@nathan> <1713509.1760721320@sss.pgh.pa.us>
 <aPKFmL8VjOKNVLcw@nathan> <1723302.1760726712@sss.pgh.pa.us>
 <aPKUzk2xFhZBbWmz@nathan>
 <78B81B37-9F27-4085-92DA-6B50DFC24361@justatheory.com>
 <CAOtk82QCHhWwO=zB-KFYch3JLf8Si4Bk77R_0cgsHjkwuhR9Vg@mail.gmail.com>
Comments: In-reply-to Mankirat Singh <mankiratsingh1315@gmail.com>
	message dated "Sat, 18 Oct 2025 18:34:17 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1957146.1760800489.1@sss.pgh.pa.us>
Date: Sat, 18 Oct 2025 11:14:49 -0400
Message-ID: <1957147.1760800489@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1957147.1760800489%40sss.pgh.pa.us>
Precedence: bulk

Mankirat Singh <mankiratsingh1315@gmail.com> writes:
> But if we want a much clearer way based on symbol names, we could use a
> standard per branch suppression file, which the abidiff tool directly
> supports for this purpose[1].

I am strongly against relying on suppression files.  I think that
is a very imprecise technology, and it is certainly harder to use
than the "choose a blessed reference point" approach.

			regards, tom lane