From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
cc: David Steele <david@pgmasters.net>, Robert Haas <robertmhaas@gmail.com>,
        David Fetter <david@fetter.org>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Magnus Hagander <magnus@hagander.net>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Heikki Linnakangas <hlinnaka@iki.fi>,
        Julian Markwort <julian.markwort@uni-muenster.de>,
        Stephen Frost <sfrost@snowman.net>,
        PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
        Valery Popov <v.popov@postgrespro.ru>
Subject: Re: Password identifiers, protocol aging and SCRAM protocol
In-reply-to: 
 <CAB7nPqRp74T70QELi8M8LHmMPXSzzBHwc3orAsQFuGbxB4o0HQ@mail.gmail.com>
References: 
 <CAB7nPqSL_V+0nD5i-XH_x1o5HTt2bT53vVwPUTHz8YT0hYRoPg@mail.gmail.com>
 <20160720181257.GA686053@alvherre.pgsql> <20160720202524.GA16111@fetter.org>
 <CAB7nPqQwR+93uLozt-CYiDnq1WPQYLYjZ5NMWs_3Pthu1pWFQQ@mail.gmail.com>
 <CA+TgmoZMn67CUgUxTD2vFgp7oHWH9qCHRUWebY6OSfSRVG5a_g@mail.gmail.com>
 <88f35221-2abd-6a31-a75d-28a3dc3a5b30@pgmasters.net>
 <29704.1469122290@sss.pgh.pa.us>
 <CAB7nPqRp74T70QELi8M8LHmMPXSzzBHwc3orAsQFuGbxB4o0HQ@mail.gmail.com>
Comments: In-reply-to Michael Paquier <michael.paquier@gmail.com>
	message dated "Fri, 22 Jul 2016 08:27:57 +0900"
Date: Thu, 21 Jul 2016 19:48:43 -0400
Message-ID: <19611.1469144923@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Michael Paquier <michael.paquier@gmail.com> writes:
> On Fri, Jul 22, 2016 at 2:31 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Note that "crypto" for this purpose generally means reversible encryption;
>> I've never heard that one-way hashes are illegal anywhere.  So password
>> hashing such as md5 is fine in core, and a stronger hash would be too.
>> But pulling in pgcrypto lock, stock, and barrel is not OK.

> So it would be an issue if pgcrypto.so links directly to libpqcommon?

No, I don't see why that'd be an issue.  What we can't do is have
libpgcommon depending on pgcrypto.so, or containing anything more than
one-way-hash functionality itself.

> Because I would like to just change my set of patches to have the SHA
> and the encoding functions in src/backend/libpq instead of src/common,
> and then have pgcrypto be compiled with a link to those files. That's
> a cleaner design btw, more in line with what is done for md5..

I'm confused.  We need that code in both libpq and backend, no?
src/common is the place for stuff of that description.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers