Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyLdI-0004Aj-A3 for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 18:05:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyLdG-0004nS-Ox for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 18:05:10 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyLdG-0004n0-EJ for pgsql-hackers@lists.postgresql.org; Tue, 20 Mar 2018 18:05:10 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyLdA-0004ld-2A for pgsql-hackers@lists.postgresql.org; Tue, 20 Mar 2018 18:05:09 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w2KI4o5E019715; Tue, 20 Mar 2018 14:04:50 -0400 From: Tom Lane To: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) cc: Craig Ringer , PostgreSQL Hackers Subject: Re: configure's checks for --enable-tap-tests are insufficient In-reply-to: References: <516.1521475003@sss.pgh.pa.us> <8906.1521513602@sss.pgh.pa.us> <9696.1521554152@sss.pgh.pa.us> <12134.1521556826@sss.pgh.pa.us> <30398.1521564644@sss.pgh.pa.us> Comments: In-reply-to ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) message dated "Tue, 20 Mar 2018 17:23:26 -0000" MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0" Content-ID: <19592.1521568956.0@sss.pgh.pa.us> Date: Tue, 20 Mar 2018 14:04:50 -0400 Message-ID: <19714.1521569090@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk ------- =_aaaaaaaaaa0 Content-Type: text/plain; charset="us-ascii" Content-ID: <19592.1521568956.1@sss.pgh.pa.us> ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: > Tom Lane writes: >> I just want to test for modules that we know are likely to be omitted >> on popular platforms. I've proposed testing two that would improve >> the user experience on Red Hat; what's the equivalent minimum set for >> Debian? > On Debian (I've checked the previous and current stable releases, as > well as unstable) the only package required by the TAP tests not in > perl-base is Time::HiRes. Of the modules required by PL/Perl, Opcode is > not in perl-base either. Ah, thanks. Not sure we need to make an explicit test for Opcode; we've not heard of anyone not having that. > BTW, should include the version in the Test::More check, since we only > requie Perl 5.8, but that only shipped Test::More 0.47, while we require > 0.97. Good point, though it looks to me like we're requiring 0.87 not 0.97? Anyway, I propose the attached. It produces output like checking for perl module IPC::Run... ok checking for perl module Test::More 0.87... no checking for perl module Time::HiRes... ok configure: error: Additional Perl modules are required to run TAP tests which seems a better approach to me than making the user find out one at a time which modules are needed. regards, tom lane ------- =_aaaaaaaaaa0 Content-Type: text/x-diff; name="check-for-more-perl-modules-in-configure.patch"; charset="us-ascii" Content-ID: <19592.1521568956.2@sss.pgh.pa.us> Content-Description: check-for-more-perl-modules-in-configure.patch Content-Transfer-Encoding: quoted-printable diff --git a/configure b/configure index 3943711..1be8a1a 100755 *** a/configure --- b/configure *************** if test "$enable_tap_tests" =3D yes; then *** 16517,16522 **** --- 16517,16528 ---- # (prove might be part of a different Perl installation than perl, eg = on # MSys, so the result of AX_PROG_PERL_MODULES could be irrelevant anyw= ay.) if test -z "$PROVE"; then + # Test::More and Time::HiRes are supposed to be part of core Perl, + # but some distros omit them in a minimal installation. + = + = + = + = = = = *************** fi *** 16566,16572 **** = if test "x$PERL" !=3D x; then ax_perl_modules_failed=3D0 ! for ax_perl_module in 'IPC::Run' ; do { $as_echo "$as_me:${as_lineno-$LINENO}: checking for perl module $a= x_perl_module" >&5 $as_echo_n "checking for perl module $ax_perl_module... " >&6; } = --- 16572,16578 ---- = if test "x$PERL" !=3D x; then ax_perl_modules_failed=3D0 ! for ax_perl_module in 'IPC::Run' 'Test::More 0.87' 'Time::HiRes' ; do { $as_echo "$as_me:${as_lineno-$LINENO}: checking for perl module $a= x_perl_module" >&5 $as_echo_n "checking for perl module $ax_perl_module... " >&6; } = *************** $as_echo "ok" >&6; }; *** 16588,16594 **** = else : ! as_fn_error $? "Perl module IPC::Run is required to run TAP tests" "= $LINENO" 5 fi else { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: could not find perl"= >&5 --- 16594,16600 ---- = else : ! as_fn_error $? "Additional Perl modules are required to run TAP test= s" "$LINENO" 5 fi else { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: could not find perl"= >&5 diff --git a/configure.in b/configure.in index 1babdbb..9a6f4b1 100644 *** a/configure.in --- b/configure.in *************** if test "$enable_tap_tests" =3D yes; then *** 2114,2121 **** # (prove might be part of a different Perl installation than perl, eg = on # MSys, so the result of AX_PROG_PERL_MODULES could be irrelevant anyw= ay.) if test -z "$PROVE"; then ! AX_PROG_PERL_MODULES(IPC::Run, , ! AC_MSG_ERROR([Perl module IPC::Run is required to run TAP tests])) fi # Now make sure we know where prove is PGAC_PATH_PROGS(PROVE, prove) --- 2114,2123 ---- # (prove might be part of a different Perl installation than perl, eg = on # MSys, so the result of AX_PROG_PERL_MODULES could be irrelevant anyw= ay.) if test -z "$PROVE"; then ! # Test::More and Time::HiRes are supposed to be part of core Perl, ! # but some distros omit them in a minimal installation. ! AX_PROG_PERL_MODULES([IPC::Run Test::More=3D0.87 Time::HiRes], , ! [AC_MSG_ERROR([Additional Perl modules are required to run TAP tes= ts])]) fi # Now make sure we know where prove is PGAC_PATH_PROGS(PROVE, prove) ------- =_aaaaaaaaaa0--