Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hB4xb-000313-Ez
	for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 21:59:19 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hB4xX-0006sJ-OH
	for pgsql-hackers@arkaria.postgresql.org; Mon, 01 Apr 2019 21:59:15 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hB4xX-0006sC-Fi
	for pgsql-hackers@lists.postgresql.org; Mon, 01 Apr 2019 21:59:15 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hB4xQ-0000f4-Rw
	for pgsql-hackers@lists.postgresql.org; Mon, 01 Apr 2019 21:59:14 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x31Lx4V2019771;
	Mon, 1 Apr 2019 17:59:04 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Fabien COELHO <coelho@cri.ensmp.fr>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Georgios Kokolatos <gkokolatos@pm.me>,
        PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: CPU costs of random_zipfian in pgbench
In-reply-to: <20190401215135.GA31141@alvherre.pgsql>
References: <20190401215135.GA31141@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Mon, 01 Apr 2019 18:51:35 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19769.1554155944.1@sss.pgh.pa.us>
Date: Mon, 01 Apr 2019 17:59:04 -0400
Message-ID: <19770.1554155944@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-Apr-01, Tom Lane wrote:
>> Seems reasonable.  Pushed with minor documentation editing.

> Ah, so we now we can get rid of the TState * being passed around
> separately for expression execution, too?

I didn't really look for follow-on simplifications, but if there
are some to be made, great.  (That would be further evidence for
my opinion that this feature was overcomplicated ...)

			regards, tom lane