Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: Do we still need gen_node_support.pl's nodetag ABI stability
 check?
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <cd9faf75-370f-4305-9644-299e4404692b@eisentraut.org>
Date: Wed, 15 Apr 2026 21:47:05 +0200
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <1977660F-C5E3-427B-AD2F-56F66803C320@yesql.se>
References: <1458883.1776143073@sss.pgh.pa.us>
 <cd9faf75-370f-4305-9644-299e4404692b@eisentraut.org>
To: Peter Eisentraut <peter@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/1977660F-C5E3-427B-AD2F-56F66803C320%40yesql.se>
Precedence: bulk

> On 15 Apr 2026, at 21:30, Peter Eisentraut <peter@eisentraut.org> =
wrote:
>=20
> On 14.04.26 07:04, Tom Lane wrote:
>> On the one hand, there's much to be said for belt-and-suspenders-too
>> safety checks.  On the other hand, updating gen_node_support.pl is
>> an extra manual step while creating a branch, so it's easy to forget
>> or get wrong.  It's also not very clear why this particular sort
>> of ABI break in a stable branch is any worse than other hazards.
>=20
> This might still be helpful because it checks during local builds and =
doesn't rely on the buildfarm.

But does it actually give a good enough answer to be relied upon when =
passing
the local check can fail the buildfarm check?

--
Daniel Gustafsson