Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: [PATCH] Add tests for Bitmapset
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: 
 <CAApHDvqiN0+mbooUOSCDALc=GoM8DmTbCdvwnCwak6Wb2O1ZJA@mail.gmail.com>
Date: Fri, 3 Oct 2025 10:25:58 +0200
Cc: Michael Paquier <michael@paquier.xyz>,
 Greg Burd <greg@burd.me>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <197CAFC2-963B-4414-9A51-08AF648146E4@yesql.se>
References: 
 <CAApHDvq-4994jpDnspQ+bgSbzo0+=Z4YQbj+YfP7wi97B0e1qg@mail.gmail.com>
 <76DBEF5D-EA47-4C30-8D28-97B3B88E2E2D@greg.burd.me>
 <CAApHDvrvixMmscGEfEyYz0=qbwzM7Y0Up-Uh_AKVmfn8K2sn_A@mail.gmail.com>
 <aNxpxE6a9G3sbfrm@paquier.xyz>
 <CAApHDvoC-W3s2QJdBY6B32BXy2br9iGsNJ3v4uLFOosBgmY2YA@mail.gmail.com>
 <aNyiu0fKRqihdwpV@paquier.xyz>
 <CAApHDvrEPw6DAQdZg7u1YknVvN1Gy38kUURQm8bOHSKU2cw+4w@mail.gmail.com>
 <aNy4xV4Fa1m9lyXX@paquier.xyz>
 <978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se>
 <CAApHDvpYkS+=KPcCvYOF4Za9=a_D94Gd9x1oCzuz97He1_T0Pw@mail.gmail.com>
 <BC483901-9587-4076-B20F-9A414C66AB78@yesql.se>
 <CAApHDvqiN0+mbooUOSCDALc=GoM8DmTbCdvwnCwak6Wb2O1ZJA@mail.gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/197CAFC2-963B-4414-9A51-08AF648146E4%40yesql.se>
Precedence: bulk

> On 3 Oct 2025, at 01:36, David Rowley <dgrowleyml@gmail.com> wrote:
>=20
> On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <daniel@yesql.se> =
wrote:
>> Another nitpick would be to remove the test for NULL in =
test_bms_make_singleton
>> since that is a STRICT function, making the test for NULL superfluous =
code:
>=20
> I see test_random_operations() is also strict. Is it worth getting rid
> of the SQL NULL checks on the inputs there too? Aka, the attached.

Indeed, but reading the code I wonder if STRICT was a mistake and the =
intention
was to allow NULL input?  That being said, the function is never called =
with
NULL so that's mostly academic thinking.  +1 for removing the NULL =
checks and
simplifying the code.

--
Daniel Gustafsson