Feedback-ID: i131946ab:Fastmail
Message-ID: <197fca5f-669b-ed76-6cc5-1dd81e63fa13@enterprisedb.com>
Date: Thu, 2 Mar 2023 09:17:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: Show various offset arrays for heap WAL records
Content-Language: en-US
To: Melanie Plageman <melanieplageman@gmail.com>, Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
References: <20230109215842.fktuhesvayno6o4g@awork3.anarazel.de>
 <CAH2-WznDAwGX4rbser=dWkXjOu91qNL8_eZiWdPh17OP+M3=6w@mail.gmail.com>
 <20230110193457.35y7s5h4bastkyd3@awork3.anarazel.de>
 <CAH2-WzmPmCQzjzTXFn=z-BFaEodzASUhmdA4CmTAb+zDrdbULw@mail.gmail.com>
 <20230111230045.dxftr4wtw2ceprti@awork3.anarazel.de>
 <CAH2-WzmqCBQj2jDmP+8N9Q+=bvZpYqVA9_EOgchPuYV7eO63NQ@mail.gmail.com>
 <CAH2-Wz=XbFAsy2-XyeA3YY9zy+EjqqL2JC9LQJZTZQTD+_p16A@mail.gmail.com>
 <CAAKRu_ZLLHKbNyKxHs5Ax6+OO0pxHL5Hq__fC7rPFBjFYhJdFg@mail.gmail.com>
 <CAH2-WznyCmZ8k4=2jJ3B7cGkjn1pDgJCv4T6qXrFh+kCO8L+iw@mail.gmail.com>
 <CAH2-Wz=acGKoP8cZ+6Af2inoai0N5cZKCY13DaqXCwQNupK8qg@mail.gmail.com>
 <CAAKRu_Ywd6Vfg9x5gDD11Xvqnnh8fkBpk+O1SmYUF-BGaSK63A@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAAKRu_Ywd6Vfg9x5gDD11Xvqnnh8fkBpk+O1SmYUF-BGaSK63A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/197fca5f-669b-ed76-6cc5-1dd81e63fa13%40enterprisedb.com>
Precedence: bulk

On 01.03.23 17:11, Melanie Plageman wrote:
> diff --git a/contrib/pg_walinspect/pg_walinspect--1.0.sql b/contrib/pg_walinspect/pg_walinspect--1.0.sql
> index 08b3dd5556..eb8ff82dd8 100644
> --- a/contrib/pg_walinspect/pg_walinspect--1.0.sql
> +++ b/contrib/pg_walinspect/pg_walinspect--1.0.sql
> @@ -17,7 +17,7 @@ CREATE FUNCTION pg_get_wal_record_info(IN in_lsn pg_lsn,
>       OUT main_data_length int4,
>       OUT fpi_length int4,
>       OUT description text,
> -    OUT block_ref text
> +    OUT block_ref int4[][]
>   )
>   AS 'MODULE_PATHNAME', 'pg_get_wal_record_info'
>   LANGUAGE C STRICT PARALLEL SAFE;

A change like this would require a new extension version and an upgrade 
script.

I suppose it's ok to postpone that work while the actual meat of the 
patch is still being worked out, but I figured I'd mention it in case it 
wasn't considered yet.