From: Tom Lane <tgl@sss.pgh.pa.us>
To: Stephen Frost <sfrost@snowman.net>
cc: Justin Pryzby <pryzby@telsasoft.com>, Fabien COELHO <coelho@cri.ensmp.fr>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        David Steele <david@pgmasters.net>, pgsql-hackers@postgresql.org,
        "Bossart, Nathan" <bossartn@amazon.com>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and
 pg_ls_*)
In-reply-to: <20201123230031.GR16415@tamriel.snowman.net>
References: <alpine.DEB.2.21.2004121145190.5257@pseudo>
 <20200503024215.GJ28974@telsasoft.com> <20200526021003.GW4472@telsasoft.com>
 <alpine.DEB.2.22.394.2006070908120.32228@pseudo>
 <20200622015325.GG17995@telsasoft.com> <20200715030839.GX23581@telsasoft.com>
 <20200718201532.GV23581@telsasoft.com> <20200908195126.GB18552@telsasoft.com>
 <20201028193402.GA28528@telsasoft.com> <129225.1606166058@sss.pgh.pa.us>
 <20201123230031.GR16415@tamriel.snowman.net>
Comments: In-reply-to Stephen Frost <sfrost@snowman.net>
	message dated "Mon, 23 Nov 2020 18:00:31 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <198111.1606172779.1@sss.pgh.pa.us>
Date: Mon, 23 Nov 2020 18:06:19 -0500
Message-ID: <198112.1606172779@sss.pgh.pa.us>
Precedence: bulk

Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> I took a quick look through this.  This is just MHO, of course:
>> 
>> * I don't think it's okay to change the existing signatures of
>> pg_ls_logdir() et al.

> I disagree that we need to stress over this- we pretty routinely change
> the signature of various catalogs and functions and anyone using these
> is already of the understanding that we are free to make such changes
> between major versions.

Well, like I said, just MHO.  Anybody else want to weigh in?

I'm mostly concerned about removing the isdir output of pg_stat_file().
Maybe we could compromise to the extent of keeping that, allowing it
to be partially duplicative of a file-type-code output column.

			regards, tom lane