From: Antonin Houska <ah@cybertec.at>
To: Richard Guo <riguo@pivotal.io>
cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>,
    PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] WIP: Aggregation push-down
In-reply-to: 
 <CAN_9JTzAsBwv5zr4SRVO35OtMWQBXSLcUuY65NQ0ZtFCTOrMMA@mail.gmail.com>
References: <29613.1502983342@localhost> <14577.1509723225@localhost>
 <CAB7nPqQgB=3ZpuvSm8hVXDcPz79kn2ZGsyyoDrmQsv-B3LDMyQ@mail.gmail.com>
 <18007.1513957437@localhost>
 <CA+Tgmob8og+9HzMg1vM+3LwDm2f_bHUi9+g1bqLDTjqpw5s+nQ@mail.gmail.com>
 <31585.1519833763@localhost> <18061.1535727958@localhost>
 <9726.1542577439@sss.pgh.pa.us> <15879.1545062283@localhost>
 <10529.1547561178@localhost> <20190204060302.GC4092@paquier.xyz>
 <25767.1549359615@localhost> <11172.1550780283@sss.pgh.pa.us>
 <23468.1551369774@localhost>
 <CAN_9JTy95UMjOVDSc-4MBrA6Fc1hX2vh=t2RMHp=yGyAV=-Xsw@mail.gmail.com>
 <1897.1562680064@spoje.net>
 <CAN_9JTzC1K-Gc3p5GD=dQeJD8k_Z5996B0rEYjVGx+pXPq8JPw@mail.gmail.com>
 <13971.1562920911@spoje.net>
 <CAN_9JTzAsBwv5zr4SRVO35OtMWQBXSLcUuY65NQ0ZtFCTOrMMA@mail.gmail.com>
Comments: In-reply-to Richard Guo <riguo@pivotal.io>
   message dated "Mon, 15 Jul 2019 18:28:15 +0800."
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Date: Wed, 17 Jul 2019 16:39:52 +0200
Message-ID: <19857.1563374392@localhost>
Precedence: bulk

--=-=-=
Content-Type: text/plain

Richard Guo <riguo@pivotal.io> wrote:

> Another core dump for query below:
> 
> select sum(t1.s1) from t1, t2, t3, t4 where t1.j1 = t2.j2 group by t1.g1, t2.g2;
> 
> This is due to a small mistake:
> 
> diff --git a/src/backend/optimizer/util/relnode.c b/src/backend/optimizer/util/relnode.c
> index 10becc0..9c2deed 100644
> --- a/src/backend/optimizer/util/relnode.c
> +++ b/src/backend/optimizer/util/relnode.c
> @@ -648,7 +648,7 @@ void
>  add_grouped_rel(PlannerInfo *root, RelOptInfo *rel, RelAggInfo *agg_info)
>  {
>         add_rel_info(root->grouped_rel_list, rel);
> -       add_rel_info(root->agg_info_list, rel);
> +       add_rel_info(root->agg_info_list, agg_info);
>  }
> 

Thanks! Yes, this is what I had to fix.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=v14-0001-Introduce-RelInfoList-structure.patch