From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Alexander Lakhin <exclusion@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Should rolpassword be toastable?
In-reply-to: <Zuwzp09o9uiG0f0F@nathan>
References: <89e8649c-eb74-db25-7945-6d6b23992394@gmail.com> <1284094.1695479962@sss.pgh.pa.us> <67793ae1-3adc-a6e0-0bb3-c23a28c0627a@gmail.com> <a9524f94-316c-349a-6e4d-79b878706f82@gmail.com> <Zuwzp09o9uiG0f0F@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Thu, 19 Sep 2024 09:22:31 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1986858.1726756275.1@sss.pgh.pa.us>
Date: Thu, 19 Sep 2024 10:31:15 -0400
Message-ID: <1986859.1726756275@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/1986859.1726756275%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> Hm.  It does seem like there's little point in giving pg_authid a TOAST
> table, as rolpassword is the only varlena column, and it obviously has
> problems.  But wouldn't removing it just trade one unhelpful internal error
> when trying to log in for another when trying to add a really long password
> hash (which hopefully nobody is really trying to do in practice)?  I wonder
> if we could make this a little more user-friendly.

We could put an arbitrary limit (say, half of BLCKSZ) on the length of
passwords.

			regards, tom lane