public inbox for [email protected]
help / color / mirror / Atom feedFrom: Zhang Mingli <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Fix outdated code comments in nodeAgg.c
Date: Sun, 9 Feb 2025 23:14:51 +0800
Message-ID: <198a8d1e-0792-4e7f-828e-902aa342f36e@Spark> (raw)
In-Reply-To: <56f5ab23-e92b-4380-929d-d2aa68ccc2ca@Spark>
References: <56f5ab23-e92b-4380-929d-d2aa68ccc2ca@Spark>
Hi,
By reading the codes in nodeAgg.c, I found that some comments are outdated.
The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
I've adjusted the comments to refer to the correct function to make it clear.
--
Zhang Mingli
HashData
Attachments:
[application/octet-stream] v0-0001-fix-update-outdated-comments-in-nodeAgg.c.patch (2.3K, ../198a8d1e-0792-4e7f-828e-902aa342f36e@Spark/3-v0-0001-fix-update-outdated-comments-in-nodeAgg.c.patch)
download | inline diff:
From 892252cfb311d6fec8520136d6f4739b0645be85 Mon Sep 17 00:00:00 2001
From: Zhang Mingli <[email protected]>
Date: Sun, 9 Feb 2025 23:08:44 +0800
Subject: [PATCH] fix: update outdated comments in nodeAgg.c
Replaced references to the removed function lookup_hash_entry() in
comments with the appropriate current function.
Authored-by: Zhang Mingli [email protected]
---
src/backend/executor/nodeAgg.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/backend/executor/nodeAgg.c b/src/backend/executor/nodeAgg.c
index 3005b5c0e3..aa8de946ed 100644
--- a/src/backend/executor/nodeAgg.c
+++ b/src/backend/executor/nodeAgg.c
@@ -1453,7 +1453,7 @@ find_cols_walker(Node *node, FindColsContext *context)
* To implement hashed aggregation, we need a hashtable that stores a
* representative tuple and an array of AggStatePerGroup structs for each
* distinct set of GROUP BY column values. We compute the hash key from the
- * GROUP BY columns. The per-group data is allocated in lookup_hash_entry(),
+ * GROUP BY columns. The per-group data is allocated in initialize_hash_entry(),
* for each entry.
*
* We have a separate hashtable and associated perhash data structure for each
@@ -1542,7 +1542,7 @@ build_hash_table(AggState *aggstate, int setno, long nbuckets)
* at all. Only columns of the first two types need to be stored in the
* hashtable, and getting rid of the others can make the table entries
* significantly smaller. The hashtable only contains the relevant columns,
- * and is packed/unpacked in lookup_hash_entry() / agg_retrieve_hash_table()
+ * and is packed/unpacked in lookup_hash_entries() / agg_retrieve_hash_table()
* into the format of the normal input descriptor.
*
* Additional columns, in addition to the columns grouped by, come from two
@@ -2077,8 +2077,6 @@ initialize_hash_entry(AggState *aggstate, TupleHashTable hashtable,
/*
* Look up hash entries for the current tuple in all hashed grouping sets.
*
- * Be aware that lookup_hash_entry can reset the tmpcontext.
- *
* Some entries may be left NULL if we are in "spill mode". The same tuple
* will belong to different groups for each grouping set, so may match a group
* already in memory for one set and match a group not in memory for another
--
2.34.1
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Fix outdated code comments in nodeAgg.c
In-Reply-To: <198a8d1e-0792-4e7f-828e-902aa342f36e@Spark>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox