From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: David Rowley <dgrowleyml@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Andres Freund <andres@anarazel.de>
Subject: Re: Making C function declaration parameter names consistent with
 corresponding definition names
In-reply-to: 
 <CAH2-Wz=Yu_Ep+eEyWYEU4bj=p0y_FgTDacJQB=YTKM8AZUKZwA@mail.gmail.com>
References: 
 <CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com>
 <3913123.1663370391@sss.pgh.pa.us>
 <CAH2-WzmxBXZAE6eyAm1XyPp6X7epCwih5qBupTxQOc6Hqp48fQ@mail.gmail.com>
 <3922750.1663372191@sss.pgh.pa.us>
 <CAH2-Wzk2etJjj8rhKn9MG9hQ2B+5tWuZneCkGyusqraGQaaeBA@mail.gmail.com>
 <3955318.1663377656@sss.pgh.pa.us>
 <CAH2-WzmykEKQzrcxHZNAuUs7GE2pL+jMa=vMZAzoXhrjG6L6XQ@mail.gmail.com>
 <CAH2-WzkxuxfhgbToOrx_tz+KObzYQP+2MN6dBQoD-jy8vC8_0Q@mail.gmail.com>
 <29327.1663439185@sss.pgh.pa.us>
 <CAH2-WzkgcxqbudmwwCREpkapnOt_svG8M+HWTPkUTv-VMmNsXQ@mail.gmail.com>
 <CAH2-Wz=VD9FgBfT8cQNez3F-R1jfSDN9LKy21GhJqQQqPJmvfA@mail.gmail.com>
 <CAApHDvoGLF+fm7BuQmgV=K9DGoBQ3cxJOWsva3naNhrWpvueNw@mail.gmail.com>
 <CAH2-WzmB6OY_fTGDg_4f8TqKEQTg7mvPtVhZ5aEBw=42ex37fQ@mail.gmail.com>
 <CAH2-WznsP1R9UrXsp5LMoRTKt5-BApZAkZ80E-qvvVSicgEoAg@mail.gmail.com>
 <CAApHDvqTu1y1V-zSk_siRVWFGoCoLQgSap0=MPXmnqeuo1ZmFA@mail.gmail.com>
 <CAH2-Wzkni0vBvB7eM9TT8DrisA_SC85BJcTFzopdeuZ+YES1YQ@mail.gmail.com>
 <CAH2-Wzkn0!
 W2SFtdPk1pFZUPF9vZy82X6D85YTVt2qq3w7hRJug@mail.gmail.com>
 <CAH2-Wzk7VatgOM0m9tpqfq_jtaYuYFK_RHoN+s=aM1Hf=xC9nQ@mail.gmail.com>
 <CAH2-WznupXdh8hZ4cjr7nVVHHPLP3w46AcKb2QXYWsPUp6LQ_A@mail.gmail.com>
 <CAH2-Wz=Yu_Ep+eEyWYEU4bj=p0y_FgTDacJQB=YTKM8AZUKZwA@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Thu, 22 Sep 2022 14:41:21 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1990813.1663883711.1@sss.pgh.pa.us>
Date: Thu, 22 Sep 2022 17:55:11 -0400
Message-ID: <1990814.1663883711@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1990814.1663883711%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> I would like to give another 24 hours for anybody to lodge final
> objections to what I've done in this patch. It seems possible that
> there will be concerns about how this might affect backpatching, or
> something like that. This patch goes relatively far in the direction
> of refactoring to make things consistent at the module level -- unlike
> most of the patches, which largely consisted of mechanical adjustments
> that were obviously correct, both locally and at the whole-module level.

Yeah.  I'm not much on board with the AHX->A and AH->A changes you made;
those seem extremely invasive and it's not real clear that they add a
lot of value.

I've never thought that the Archive vs. ArchiveHandle separation in
pg_dump was very well thought out.  I could perhaps get behind a patch
to eliminate that bit of "abstraction"; but I'd still try to avoid
wholesale changes in local-variable names from it.  I don't think that
would buy anything that's worth the back-patching pain.  Just accepting
that Archive[Handle] variables might be named either AH or AHX depending
on historical accident does not seem that bad to me.  We have lots more
and worse naming inconsistencies in our tree.

			regards, tom lane