From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <jcnaylor@gmail.com>
cc: Stas Kelvich <s.kelvich@postgrespro.ru>, andreas@proxel.se,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        David Fetter <david@fetter.org>
Subject: Re: unused_oids script is broken with bsd sed
In-reply-to: 
 <CAJVSVGU0cPPwMhCfVz5PvpTDrjZzeT=0QHUhMbg=MjaMO_Gr+A@mail.gmail.com>
References: <37D774E4-FE1F-437E-B3D2-593F314B7505@postgrespro.ru>
 <34a54c54-9132-1254-2bc3-d3489fb79728@2ndQuadrant.com>
 <4473.1524665917@sss.pgh.pa.us>
 <4DE444D1-DDE9-460F-AC2F-EB1B73D94A2D@postgrespro.ru>
 <CAJVSVGU2w6rvTXghDe7-Y3x9Ca0833VmnC3HpaYKGLw4xznpJA@mail.gmail.com>
 <26728623-7783-4103-9BED-08D443C1729F@postgrespro.ru>
 <CAJVSVGU0cPPwMhCfVz5PvpTDrjZzeT=0QHUhMbg=MjaMO_Gr+A@mail.gmail.com>
Comments: In-reply-to John Naylor <jcnaylor@gmail.com>
	message dated "Thu, 26 Apr 2018 02:09:47 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19972.1524686883.1@sss.pgh.pa.us>
Date: Wed, 25 Apr 2018 16:08:03 -0400
Message-ID: <19973.1524686883@sss.pgh.pa.us>
Precedence: bulk

John Naylor <jcnaylor@gmail.com> writes:
> Just after you posted, I sent a patch that tweaks the API of
> Catalog.pm for toast and index oids. If you use that API in your
> patch, you can get rid of the extra bookkeeping you added for those
> oids.

I've adjusted these two patches to play together, and pushed them.

> The original scripts skipped the relation and rowtype oids for
> bootstrap catalogs. You've replaced that with two data-level tests for
> pg_class plus pg_type composite types. I think the original test was a
> bit cleaner in this regard.

Yeah, I thought so too.  Changed.

> For those following along, these scripts still assume we're in the
> catalog directory. I can hack on that part tomorrow if no one else
> has.

I didn't touch this point.

I notice that duplicate_oids is now a good factor of 10 slower than it was
before (~0.04 sec to ~0.4 sec, on my machine).  While this doesn't seem
like a problem for manual use, it seems annoying as part of the standard
build process, especially on slower buildfarm critters.  I think we should
do what you said upthread and teach genbki.pl to complain about duplicate
oids, so that we can remove duplicate_oids from the build process.

I went ahead and pushed things as-is so we can confirm that duplicate_oids
has no portability issues that the buildfarm could find.  But let's try
to get the build process change in place after a day or so.

			regards, tom lane