From: Bruce Momjian <maillist@candle.pha.pa.us>
Message-Id: <199808251731.NAA01138@candle.pha.pa.us>
Subject: Re: [HACKERS] Open 6.4 items
In-Reply-To: <35E25993.CA72C45C@alumni.caltech.edu> from "Thomas G. Lockhart"
	at "Aug 25, 1998  6:28:35 am"
To: lockhart@alumni.caltech.edu (Thomas G. Lockhart)
Date: Tue, 25 Aug 1998 13:31:31 -0400 (EDT)
Cc: t-ishii@sra.co.jp, hackers@postgreSQL.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

> > > > SERIAL type auto-creates sequence
> > This would be nice to have for 6.4.  Someone mentioned you can create
> > the sequence before the table, so maybe we can jam it in. If it is not
> > 100% correct, we have a month to make it correct, right?
> 
> postgres=> create table s (x text, i serial);
> NOTICE:  CREATE TABLE will create implicit sequence s_i_seq for SERIAL
> column s.i
> CREATE
> postgres=> insert into s values ('one');
> INSERT 894455 1
> postgres=> insert into s values ('two');
> INSERT 894456 1
> postgres=> insert into s values ('three');
> INSERT 894457 1
> postgres=> select * from s;
> x    |i
> -----+-
> one  |1
> two  |2
> three|3
> (3 rows)

Great.

> 
> > > > remove PARSEDEBUG defines if not longer needed
> > Remember, I suggested a way you could keep them with more eligant
> > defines.  Any comments?
> 
> Well, I think that at least most of them should come out of the code
> altogether. The more elegant solution probably leads to code clutter
> also, just a bit more readable since it indents with the rest of the
> code.

OK.  I just redid parse_target.c, so I hope you can merge in your stuff.

> 
> > > > double-quotes from pg_dump of field names
> > > I have some patches for this, but have not had time to test yet.
> > Cool.  Let the beta testers test it!
> 
> Hmm. So that would make them alpha testers, right? :) Might be OK for
> this one, if someone is willing to try it. I'd hate to make a change and
> then forget about it though. Tatsuo?


-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)