Received: from candle.pha.pa.us (maillist@s5-03.ppp.op.net [209.152.195.67]) by hub.org (8.8.8/8.8.8) with ESMTP id LAA05404 for ; Mon, 12 Oct 1998 11:57:52 -0400 (EDT) (envelope-from maillist@candle.pha.pa.us) Received: (from maillist@localhost) by candle.pha.pa.us (8.9.0/8.9.0) id LAA12136; Mon, 12 Oct 1998 11:57:14 -0400 (EDT) From: Bruce Momjian Message-Id: <199810121557.LAA12136@candle.pha.pa.us> Subject: Re: [HACKERS] Open 6.4 items In-Reply-To: <86ww65yfmu.fsf@athene.nhh.no> from Tom Ivar Helbekkmo at "Oct 12, 1998 5:16:41 pm" To: tih@nhh.no (Tom Ivar Helbekkmo) Date: Mon, 12 Oct 1998 11:57:13 -0400 (EDT) Cc: lockhart@alumni.caltech.edu, taral@mail.utexas.edu, hackers@postgreSQL.org X-Mailer: ELM [version 2.4ME+ PL47 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Both applied, with the first one reverse applied. Thanks. > Bruce Momjian writes: > > > I have lost it. Could someone resend it, and the patch to reverse too. > > This is the one that shouldn't have been applied: > > Index: inet_net_pton.c > =================================================================== > RCS file: /usr/local/cvsroot/pgsql/src/backend/utils/adt/inet_net_pton.c,v > retrieving revision 1.2 > diff -r1.2 inet_net_pton.c > 120c120 > < else if (size-- > 0) > --- > > else if (--size > 0) > > This is the one that works: > > Index: inet_net_pton.c > =================================================================== > RCS file: /usr/local/cvsroot/pgsql/src/backend/utils/adt/inet_net_pton.c,v > retrieving revision 1.2 > diff -r1.2 inet_net_pton.c > 108c108,109 > < *dst = 0, dirty = 0; > --- > > tmp = 0; > > dirty = 0; > 117,122c118,127 > < *dst |= n; > < if (!dirty++) > < *dst <<= 4; > < else if (size-- > 0) > < *++dst = 0, dirty = 0; > < else > --- > > tmp = (tmp << 4) | n; > > if (++dirty == 2) { > > if (size-- <= 0) > > goto emsgsize; > > *dst++ = (u_char) tmp; > > tmp = 0, dirty = 0; > > } > > } > > if (dirty) { > > if (size-- <= 0) > 123a129,130 > > tmp <<= 4; > > *dst++ = (u_char) tmp; > 125,126d131 > < if (dirty) > < size--; > > -tih > -- > Popularity is the hallmark of mediocrity. --Niles Crane, "Frasier" > -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026