public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Karina Litskevich <[email protected]>
Cc: Pavel Borisov <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Invalid "trailing junk" error message when non-English letters are used
Date: Thu, 05 Sep 2024 12:49:42 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACiT8iaMW47nEzXSAiBNVaoapw7v0FSQ2j_TWi8ecWqynF2ngg@mail.gmail.com>
References: <CACiT8iZ_diop=0zJ7zuY3BXegJpkKK1Av-PU7xh0EDYHsa5+=g@mail.gmail.com>
	<CALT9ZEFG8u=+pBMkON1Ske+We6wtjf=A2SYGvhsZJn5TaHLwLA@mail.gmail.com>
	<CACiT8iZb+o_=MGJ72qM8HOuam0-hv09bj8-9x-XsODH1PrwP_A@mail.gmail.com>
	<[email protected]>
	<CACiT8iaf-ONO6sF0nC-9ZMpO7jq0eWUkEQXuVznegi3agGzWxw@mail.gmail.com>
	<CACiT8iaMW47nEzXSAiBNVaoapw7v0FSQ2j_TWi8ecWqynF2ngg@mail.gmail.com>

Karina Litskevich <[email protected]> writes:
> On Thu, Sep 5, 2024 at 6:07 PM Karina Litskevich
> <[email protected]> wrote:
>> In v3 of the patch I grouped all the *_junk rules together and included
>> the suggested comment with a little added something.

> Oops, I forgot to attach the patch, here it is.

Pushed with a bit of further wordsmithing on the comment.

I left out the proposed new test case "SELECT 1ä;".  The trouble
with that is it'd introduce an encoding dependency into the test.
For example, it'd likely fail with some other error message in
a server encoding that lacks an equivalent to UTF8 "ä".  While
we have methods for coping with such cases, it requires some
pushups, and I didn't see the value.  The changes in existing
test case results are sufficient to show the patch does what
we want.

Also, while the bug exists in v15, the patch didn't apply at all.
I got lazy and just did the minimal s/ident_start/identifier/ change
in that branch, instead of back-patching the cosmetic aspects.

			regards, tom lane

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Invalid "trailing junk" error message when non-English letters are used
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox