Subject: Re: Kerberos delegation support in libpq and postgres_fdw
To: Peifeng Qiu <peifengq@vmware.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>, Stephen Frost
 <sfrost@snowman.net>, Tom Lane <tgl@sss.pgh.pa.us>
References: 
 <CO1PR05MB8023CC2CB575E0FAAD7DF4F8A8E29@CO1PR05MB8023.namprd05.prod.outlook.com>
 <CO1PR05MB80235F71EE030594A275AF5DA8E49@CO1PR05MB8023.namprd05.prod.outlook.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <19afb899-318d-c61f-2de4-0e7dcbf5e0fd@enterprisedb.com>
Date: Wed, 1 Sep 2021 10:57:20 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: 
 <CO1PR05MB80235F71EE030594A275AF5DA8E49@CO1PR05MB8023.namprd05.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/19afb899-318d-c61f-2de4-0e7dcbf5e0fd%40enterprisedb.com>
Precedence: bulk

On 22.07.21 10:39, Peifeng Qiu wrote:
> I've slightly modified the patch to support "gssencmode" and added TAP 
> tests.

For the TAP tests, please put then under src/test/kerberos/, instead of 
copying the whole infrastructure to contrib/postgres_fdw/.  Just make a 
new file, for example t/002_postgres_fdw_proxy.pl, and put your tests there.

Also, you can put code and tests in one patch, no need to separate.

I wonder if this feature would also work in dblink.  Since there is no 
substantial code changes in postgres_fdw itself as part of this patch, I 
would suspect yes.  Can you check?