Content-Type: multipart/mixed; boundary="------------wGIhqGkxyhBcThZzJwPAOdGq"
Message-ID: <19c1e04c-2012-4475-8460-821dd633a6ce@postgrespro.ru>
Date: Fri, 9 Aug 2024 10:18:29 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Noah Misch <noah@leadboat.com>, Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
References: <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
 <171085858750.2046434.12246066729700037354.pgcf@coridan.postgresql.org>
 <909e16b4-9eda-435c-b033-8294ae4adc05@postgrespro.ru>
 <CAPpHfdsVQwnZPxaQPwcu1g_01F0d-o=ECRcf14X3CmavJB6vSQ@mail.gmail.com>
 <a83d5a56-ff33-47e8-b2d8-7e9a5d59ee1e@postgrespro.ru>
 <CAPpHfdsCCV8DOv0Ovu4dTSnuWXiEz_AjuW-J6TPj++tcfEGvRw@mail.gmail.com>
 <3a4b9c1c-3edf-4e29-9629-b4113aefb0f3@postgrespro.ru>
 <CAPpHfduNYkMVuUSxZjD6u4tZG6aKdhgQcmhr-K9OQfeg56MNww@mail.gmail.com>
 <c3730d78-6081-4c41-9715-d1d192734576@postgrespro.ru>
 <CAPpHfdtj7YsPaASoVPN+N3H4_Ct+kQw8QY1d_9u7FPnbghkicw@mail.gmail.com>
 <20240808171351.a9.nmisch@google.com>
Content-Language: en-US
From: Dmitry Koval <d.koval@postgrespro.ru>
In-Reply-To: <20240808171351.a9.nmisch@google.com>
Archived-At: <https://www.postgresql.org/message-id/19c1e04c-2012-4475-8460-821dd633a6ce%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------wGIhqGkxyhBcThZzJwPAOdGq
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

> This breaks from the CVE-2014-0062 (commit 5f17304) principle of not repeating
> name lookups.  The attached demo uses this defect to make one partition have
> two parents.

Thank you very much for information (especially for the demo)!

I'm not sure that we can get the identifier of the newly created 
partition from the ProcessUtility() function...
Maybe it would be enough to check that the new partition is located in 
the namespace in which we created it (see attachment)?

-- 
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com
--------------wGIhqGkxyhBcThZzJwPAOdGq
Content-Type: text/plain; charset=UTF-8; name="namespace-check.diff"
Content-Disposition: attachment; filename="namespace-check.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jIGIvc3JjL2Jh
Y2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKaW5kZXggMGIyYTUyNDYzZi4uYTE5MzdkMDc4
YiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKKysrIGIv
c3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKQEAgLTIwMzg4LDYgKzIwMzg4LDE0
IEBAIGNyZWF0ZVBhcnRpdGlvblRhYmxlKFJhbmdlVmFyICpuZXdQYXJ0TmFtZSwgUmVsYXRp
b24gbW9kZWxSZWwsCiAJICovCiAJbmV3UmVsID0gdGFibGVfb3BlbnJ2KG5ld1BhcnROYW1l
LCBOb0xvY2spOwogCisJLyogQ2hlY2sgZm9yIGNhc2UgbmFtZXNwYWNlIHdhcyByZW5hbWVk
IGR1cmluZyBwYXJ0aXRpb24gY3JlYXRpb24uICovCisJaWYgKFJlbGF0aW9uR2V0TmFtZXNw
YWNlKG5ld1JlbCkgIT0gUmVsYXRpb25HZXROYW1lc3BhY2UobW9kZWxSZWwpKQorCQllcmVw
b3J0KEVSUk9SLAorCQkJCShlcnJjb2RlKEVSUkNPREVfV1JPTkdfT0JKRUNUX1RZUEUpLAor
CQkJCSBlcnJtc2coImNhbm5vdCBjcmVhdGUgcGFydGl0aW9uIGJlY2F1c2UgbmFtZXNwYWNl
IFwiJXNcIiB3YXMgY2hhbmdlZCB0byBcIiVzXCIiLAorCQkJCQkJZ2V0X25hbWVzcGFjZV9u
YW1lKFJlbGF0aW9uR2V0TmFtZXNwYWNlKG5ld1JlbCkpLAorCQkJCQkJZ2V0X25hbWVzcGFj
ZV9uYW1lKFJlbGF0aW9uR2V0TmFtZXNwYWNlKG1vZGVsUmVsKSkpKSk7CisKIAkvKgogCSAq
IFdlIGludGVuZGVkIHRvIGNyZWF0ZSB0aGUgcGFydGl0aW9uIHdpdGggdGhlIHNhbWUgcGVy
c2lzdGVuY2UgYXMgdGhlCiAJICogcGFyZW50IHRhYmxlLCBidXQgd2Ugc3RpbGwgbmVlZCB0
byByZWNoZWNrIGJlY2F1c2UgdGhhdCBtaWdodCBiZQo=

--------------wGIhqGkxyhBcThZzJwPAOdGq--