Content-Type: multipart/alternative;
 boundary="------------Nxpu9F9TcGUx5i91T7w6CQ2T"
Message-ID: <19f7795b-a31c-491f-ad2a-746f0dd3c7c8@postgrespro.ru>
Date: Mon, 12 Feb 2024 11:55:40 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC, WIP: OR-clause support for indexes
Content-Language: en-US
To: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Cc: Alexander Korotkov <aekorotkov@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org,
 Peter Geoghegan <pg@bowt.ie>, "Finnerty, Jim" <jfinnert@amazon.com>,
 Marcos Pegoraro <marcos@f10.com.br>, teodor@sigaev.ru,
 Ranier Vilela <ranier.vf@gmail.com>,
 Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Peter Eisentraut <peter@eisentraut.org>,
 jian he <jian.universality@gmail.com>
References: <567ED6CA.2040504@sigaev.ru>
 <04ef16eb-46c1-4ce7-9f68-d1c80ef0be81@postgrespro.ru>
 <CA+TgmoZCgP6FrBQEusn4yaWm02XU8OPeoEMk91q7PRBgwaAkFw@mail.gmail.com>
 <cfdc7fef-cf0b-437b-89fa-62ffd6677f7d@postgrespro.ru>
 <59e67a40-95a8-4d74-ae4e-027ea0f59084@postgrespro.ru>
 <59b77a8a-29d6-4727-bf26-4a30a6a9719a@postgrespro.ru>
 <32d23d97-d07f-4d44-9933-ba3295fb3ed8@postgrespro.ru>
 <aec17a1a-9de0-4994-8a53-c6b4e64afb17@postgrespro.ru>
 <CACJufxGXhJ823cdAdp2Ho7qC-HZ3_-dtdj-myaAi_u9RQLn45g@mail.gmail.com>
 <CACJufxG=wB6qLbOAWaYEQHccN+qi=6-pw7zKVWZ53ZiDZNRTRA@mail.gmail.com>
 <CACJufxFrZS07oBHMk1_c8P3A84VZ3ysXiZV8NeU6gAnvu+HsVA@mail.gmail.com>
 <a155849d-7e74-4700-8c55-8a945d42935e@postgrespro.ru>
 <CACJufxFS-xcjaWq2Du2OyJUjRAyqCk12Q_zGOPxv61sgrdpw9w@mail.gmail.com>
 <7e11e27b-7ab9-4d59-af0a-a921861a9206@postgrespro.ru>
 <13ad923a-33df-4b44-9e00-c9323cd4c37d@postgrespro.ru>
 <CACJufxGfWnv9Q+sJ9iOR4w8si0cEa8wuOw=-+qRjrq4ZKdEhLg@mail.gmail.com>
 <a7a63043-e56e-4a14-bed4-b5f12081c2f0@postgrespro.ru>
From: Alena Rybakina <a.rybakina@postgrespro.ru>
In-Reply-To: <a7a63043-e56e-4a14-bed4-b5f12081c2f0@postgrespro.ru>
Archived-At: <https://www.postgresql.org/message-id/19f7795b-a31c-491f-ad2a-746f0dd3c7c8%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------Nxpu9F9TcGUx5i91T7w6CQ2T
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi!

I can't unnderstand this part of code:

/* Time to generate index paths */

MemSet(&clauseset, 0, sizeof(clauseset));
match_clauses_to_index(root, list_make1(rinfo1), index, &clauseset);

As I understand it, match_clauses_to_index is necessary if you have a 
RestrictInfo (rinfo1) variable, so maybe we should run it after the 
make_restrictonfo procedure, otherwise calling it, I think, is useless.

-- 
Regards,
Alena Rybakina
Postgres Professional:http://www.postgrespro.com
The Russian Postgres Company

--------------Nxpu9F9TcGUx5i91T7w6CQ2T
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hi!</p>
    <p>I can't unnderstand this part of code:<br>
      <br>
    </p>
    <font size="4" face="monospace">/* Time to generate index paths */<br>
      <br>
      MemSet(&amp;clauseset, 0, sizeof(clauseset));<br>
      match_clauses_to_index(root, list_make1(rinfo1), index,
      &amp;clauseset);</font><br>
    <p></p>
    <p>As I understand it, match_clauses_to_index is necessary if you
      have a RestrictInfo (rinfo1) variable, so maybe we should run it
      after the make_restrictonfo procedure, otherwise calling it, I
      think, is useless.</p>
    <p></p>
    <pre class="moz-signature" cols="72">-- 
Regards,
Alena Rybakina
Postgres Professional: <a class="moz-txt-link-freetext" href="http://www.postgrespro.com">http://www.postgrespro.com</a>
The Russian Postgres Company</pre>
  </body>
</html>

--------------Nxpu9F9TcGUx5i91T7w6CQ2T--